Ensure unused bits being zero in writeVarint32, see #13

Author: dcodeIO

dist/ByteBufferAB.js

@@ -1063,7 +1063,7 @@
                         b = (value >> 21) | 0x80;
                         this.view.setUint8(offset+3, b);
                         if (value >= 1 << 28) {
-                            this.view.setUint8(offset+4, (value >> 28) & 0x7F);
+                            this.view.setUint8(offset+4, (value >> 28) & 0x0F);
                             size = 5;
                         } else {
                             this.view.setUint8(offset+3, b & 0x7F);

dist/ByteBufferAB.min.js

@@ -1219,7 +1219,7 @@ module.exports = (function() {
                     b = (value >> 21) | 0x80;
                     this.buffer[offset+3] = b;
                     if (value >= 1 << 28) {
-                        this.buffer[offset+4] = (value >> 28) & 0x7F;
+                        this.buffer[offset+4] = (value >> 28) & 0x0F;
                         size = 5;
                     } else {
                         this.buffer[offset+3] = b & 0x7F;

dist/ByteBufferAB.min.js.gz

@@ -88,9 +88,9 @@ ByteBuffer.prototype.writeVarint32 = function(value, offset) {
                 this.view.setUint8(offset+3, b);
                 if (value >= 1 << 28) {
                     //? if (NODE)
-                    this.buffer[offset+4] = (value >> 28) & 0x7F;
+                    this.buffer[offset+4] = (value >> 28) & 0x0F;
                     //? else
-                    this.view.setUint8(offset+4, (value >> 28) & 0x7F);
+                    this.view.setUint8(offset+4, (value >> 28) & 0x0F);
                     size = 5;
                 } else {
                     //? if (NODE)

dist/ByteBufferAB.min.map

@@ -525,7 +525,7 @@ function makeSuite(ByteBuffer) {
         ["Uint64"  , null    , 8    , new Long(0xFFFFFFFE, 0xFFFFFFFF, false) , new Long(0xFFFFFFFE, 0xFFFFFFFF, true)  , "fffffffffffffffe"    ],
 
         // name    | alias   | size | input                                   | output                                  | representation
-        ["Varint32", null    , 5    , 0xFFFFFFFE                              , -2                                      , "feffffff7f"          ],
+        ["Varint32", null    , 5    , 0xFFFFFFFE                              , -2                                      , "feffffff0f"          ],
         ["Varint64", null    , 10   , new Long(0xFFFFFFFE, 0xFFFFFFFF, true)  , new Long(0xFFFFFFFE, 0xFFFFFFFF, false) , "feffffffffffffffff01"]
     ];