@@ -212,7 +212,6 @@ tape.test("feature resolution inheritance message to oneofs", function(test) {
212
212
message Message {
213
213
option features.json_format = LEGACY_BEST_EFFORT;
214
214
oneof SomeOneOf {
215
- option features.json_format = ALLOW;
216
215
int32 a = 13;
217
216
string b = 14;
218
217
}
@@ -221,7 +220,7 @@ tape.test("feature resolution inheritance message to oneofs", function(test) {
221
220
test . same ( rootEditionsOverriden . lookup ( "SomeOneOf" ) . _features , {
222
221
enum_type : 'OPEN' ,
223
222
field_presence : 'EXPLICIT' ,
224
- json_format : 'ALLOW ' ,
223
+ json_format : 'LEGACY_BEST_EFFORT ' ,
225
224
message_encoding : 'LENGTH_PREFIXED' ,
226
225
repeated_field_encoding : 'PACKED' ,
227
226
utf8_validation : 'VERIFY' ,
@@ -289,18 +288,20 @@ tape.test("feature resolution inheritance message to extensions", function(test)
289
288
option features.json_format = LEGACY_BEST_EFFORT;
290
289
option features.(abc).d_e = deeply_nested_false;
291
290
292
- extend Message {
293
- int32 bar = 10 [features.utf8_validation = NONE];
294
- }
295
- message Message {}` ) . root . resolveAll ( ) ;
291
+ message Message {
292
+ option features.utf8_validation = NONE;
293
+ extend Message {
294
+ int32 bar = 10 [features.utf8_validation = VERIFY];
295
+ }
296
+ }` ) . root . resolveAll ( ) ;
296
297
297
298
test . same ( rootEditionsOverriden . lookup ( ".bar" ) . _features , {
298
299
enum_type : 'OPEN' ,
299
300
field_presence : 'EXPLICIT' ,
300
301
json_format : 'LEGACY_BEST_EFFORT' ,
301
302
message_encoding : 'LENGTH_PREFIXED' ,
302
303
repeated_field_encoding : 'PACKED' ,
303
- utf8_validation : 'NONE ' ,
304
+ utf8_validation : 'VERIFY ' ,
304
305
'(abc)' : { d_e : 'deeply_nested_false' }
305
306
} )
306
307
@@ -333,7 +334,7 @@ tape.test("feature resolution inheritance message to enum", function(test) {
333
334
test . end ( ) ;
334
335
} ) ;
335
336
336
- tape . test ( "feature resolution inheritance message to enum" , function ( test ) {
337
+ tape . test ( "feature resolution inheritance file to enum" , function ( test ) {
337
338
338
339
var rootEditionsOverriden = protobuf . parse ( `edition = "2023";
339
340
option features.json_format = LEGACY_BEST_EFFORT;
0 commit comments