Skip to content

Update pbts.js: use spawn instead of exec #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update pbts.js: use spawn instead of exec #2082

wants to merge 1 commit into from

Conversation

wyattscarpenter
Copy link

Fixes #2081 "pbts does not properly handle filepaths with special characters in it"

@wyattscarpenter
Update pbts.js: use spawn instead of exec
663e43e 
Fixes protobufjs#2081 "pbts does not properly handle filepaths with special characters in it"
@wyattscarpenter
Copy link
Author

This worked on my code, apparently, but I'm hoping you guys also have some comprehensive tests.

@0f-0b
Copy link

0f-0b commented Jun 30, 2025

Haven't tested, but this change possibly also brings Deno compatibility: denoland/deno#29944 is caused by using exec here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pbts does not properly handle filepaths with special characters in it
2 participants
@wyattscarpenter @0f-0b