Skip to content

Commit 5e98d4d

Browse files
committed
refactor: add bom for dependency management
Signed-off-by: moxiaoying <[email protected]>
1 parent 5da5e3c commit 5e98d4d

File tree

7 files changed

+100
-61
lines changed

7 files changed

+100
-61
lines changed

bookkeeper-admin-api/pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
<modelVersion>4.0.0</modelVersion>
66
<parent>
77
<groupId>io.github.protocol-laboratory</groupId>
8-
<artifactId>bookkeeper-admin-parent</artifactId>
8+
<artifactId>bookkeeper-parent</artifactId>
99
<version>0.1.0</version>
10+
<relativePath>../bookkeeper-parent</relativePath>
1011
</parent>
1112

1213
<artifactId>bookkeeper-admin-api</artifactId>

bookkeeper-admin-common/pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
<modelVersion>4.0.0</modelVersion>
66
<parent>
77
<groupId>io.github.protocol-laboratory</groupId>
8-
<artifactId>bookkeeper-admin-parent</artifactId>
8+
<artifactId>bookkeeper-parent</artifactId>
99
<version>0.1.0</version>
10+
<relativePath>../bookkeeper-parent</relativePath>
1011
</parent>
1112

1213
<artifactId>bookkeeper-admin-common</artifactId>

bookkeeper-admin-reactive/pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
<modelVersion>4.0.0</modelVersion>
66
<parent>
77
<groupId>io.github.protocol-laboratory</groupId>
8-
<artifactId>bookkeeper-admin-parent</artifactId>
8+
<artifactId>bookkeeper-parent</artifactId>
99
<version>0.1.0</version>
10+
<relativePath>../bookkeeper-parent</relativePath>
1011
</parent>
1112

1213
<artifactId>bookkeeper-admin-reactive</artifactId>

bookkeeper-admin/pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@
55
<modelVersion>4.0.0</modelVersion>
66
<parent>
77
<groupId>io.github.protocol-laboratory</groupId>
8-
<artifactId>bookkeeper-admin-parent</artifactId>
8+
<artifactId>bookkeeper-parent</artifactId>
99
<version>0.1.0</version>
10+
<relativePath>../bookkeeper-parent</relativePath>
1011
</parent>
1112

1213
<artifactId>bookkeeper-admin</artifactId>

bookkeeper-bom/pom.xml

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<project xmlns="http://maven.apache.org/POM/4.0.0"
3+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
4+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
5+
<modelVersion>4.0.0</modelVersion>
6+
7+
<parent>
8+
<groupId>io.github.protocol-laboratory</groupId>
9+
<artifactId>bookkeeper-admin-parent</artifactId>
10+
<version>0.1.0</version>
11+
</parent>
12+
13+
<artifactId>bookkeeper-bom</artifactId>
14+
<packaging>pom</packaging>
15+
<properties>
16+
<annotations.version>13.0</annotations.version>
17+
<embedded-bookkeeper.version>0.0.1</embedded-bookkeeper.version>
18+
<http-facade.version>0.4.0</http-facade.version>
19+
<jackson.version>2.17.2</jackson.version>
20+
<junit.version>5.11.0</junit.version>
21+
<log4j.version>2.20.0</log4j.version>
22+
<lombok.version>1.18.34</lombok.version>
23+
<reactor-netty.version>1.1.22</reactor-netty.version>
24+
</properties>
25+
26+
<dependencyManagement>
27+
<dependencies>
28+
<dependency>
29+
<groupId>com.fasterxml.jackson</groupId>
30+
<artifactId>jackson-bom</artifactId>
31+
<version>${jackson.version}</version>
32+
<type>pom</type>
33+
<scope>import</scope>
34+
</dependency>
35+
</dependencies>
36+
</dependencyManagement>
37+
</project>

bookkeeper-parent/pom.xml

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<project xmlns="http://maven.apache.org/POM/4.0.0"
3+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
4+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
5+
<modelVersion>4.0.0</modelVersion>
6+
7+
<parent>
8+
<groupId>io.github.protocol-laboratory</groupId>
9+
<artifactId>bookkeeper-bom</artifactId>
10+
<version>0.1.0</version>
11+
<relativePath>../bookkeeper-bom</relativePath>
12+
</parent>
13+
14+
<artifactId>bookkeeper-parent</artifactId>
15+
<packaging>pom</packaging>
16+
17+
<dependencies>
18+
<dependency>
19+
<groupId>org.projectlombok</groupId>
20+
<artifactId>lombok</artifactId>
21+
<version>${lombok.version}</version>
22+
</dependency>
23+
<dependency>
24+
<groupId>org.jetbrains</groupId>
25+
<artifactId>annotations</artifactId>
26+
<version>${annotations.version}</version>
27+
</dependency>
28+
<dependency>
29+
<groupId>com.fasterxml.jackson.core</groupId>
30+
<artifactId>jackson-databind</artifactId>
31+
</dependency>
32+
<dependency>
33+
<groupId>org.junit.jupiter</groupId>
34+
<artifactId>junit-jupiter-engine</artifactId>
35+
<version>${junit.version}</version>
36+
<scope>test</scope>
37+
</dependency>
38+
<dependency>
39+
<groupId>org.apache.logging.log4j</groupId>
40+
<artifactId>log4j-slf4j-impl</artifactId>
41+
<version>${log4j.version}</version>
42+
<scope>test</scope>
43+
</dependency>
44+
<dependency>
45+
<groupId>io.github.embedded-middleware</groupId>
46+
<artifactId>embedded-bookkeeper-core</artifactId>
47+
<version>${embedded-bookkeeper.version}</version>
48+
<scope>test</scope>
49+
</dependency>
50+
</dependencies>
51+
</project>

pom.xml

Lines changed: 4 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010
<packaging>pom</packaging>
1111

1212
<modules>
13+
<module>bookkeeper-bom</module>
14+
<module>bookkeeper-parent</module>
1315
<module>bookkeeper-admin</module>
1416
<module>bookkeeper-admin-api</module>
1517
<module>bookkeeper-admin-common</module>
@@ -21,19 +23,11 @@
2123
<maven.compiler.target>8</maven.compiler.target>
2224
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
2325
<src.dir>src/main/java</src.dir>
24-
<!-- dependency -->
25-
<annotations.version>13.0</annotations.version>
26-
<embedded-bookkeeper.version>0.0.1</embedded-bookkeeper.version>
27-
<http-facade.version>0.4.0</http-facade.version>
28-
<jackson.version>2.17.2</jackson.version>
29-
<junit.version>5.11.0</junit.version>
30-
<log4j.version>2.20.0</log4j.version>
31-
<lombok.version>1.18.34</lombok.version>
32-
<puppycrawl.version>10.18.0</puppycrawl.version>
33-
<reactor-netty.version>1.1.22</reactor-netty.version>
3426
<!-- plugin -->
27+
<lombok.version>1.18.34</lombok.version>
3528
<lombok-maven-plugin.version>1.18.20.0</lombok-maven-plugin.version>
3629
<jacoco-maven-plugin.version>0.8.12</jacoco-maven-plugin.version>
30+
<puppycrawl.version>10.18.0</puppycrawl.version>
3731
<maven-compiler-plugin.version>3.13.0</maven-compiler-plugin.version>
3832
<maven-checkstyle-plugin.version>3.5.0</maven-checkstyle-plugin.version>
3933
<maven-enforcer-plugin.version>3.5.0</maven-enforcer-plugin.version>
@@ -49,53 +43,6 @@
4943
<spotless-maven-plugin.version>2.43.0</spotless-maven-plugin.version>
5044
</properties>
5145

52-
<dependencyManagement>
53-
<dependencies>
54-
<dependency>
55-
<groupId>com.fasterxml.jackson</groupId>
56-
<artifactId>jackson-bom</artifactId>
57-
<version>${jackson.version}</version>
58-
<type>pom</type>
59-
<scope>import</scope>
60-
</dependency>
61-
</dependencies>
62-
</dependencyManagement>
63-
64-
<dependencies>
65-
<dependency>
66-
<groupId>org.projectlombok</groupId>
67-
<artifactId>lombok</artifactId>
68-
<version>${lombok.version}</version>
69-
</dependency>
70-
<dependency>
71-
<groupId>org.jetbrains</groupId>
72-
<artifactId>annotations</artifactId>
73-
<version>${annotations.version}</version>
74-
</dependency>
75-
<dependency>
76-
<groupId>com.fasterxml.jackson.core</groupId>
77-
<artifactId>jackson-databind</artifactId>
78-
</dependency>
79-
<dependency>
80-
<groupId>org.junit.jupiter</groupId>
81-
<artifactId>junit-jupiter-engine</artifactId>
82-
<version>${junit.version}</version>
83-
<scope>test</scope>
84-
</dependency>
85-
<dependency>
86-
<groupId>org.apache.logging.log4j</groupId>
87-
<artifactId>log4j-slf4j-impl</artifactId>
88-
<version>${log4j.version}</version>
89-
<scope>test</scope>
90-
</dependency>
91-
<dependency>
92-
<groupId>io.github.embedded-middleware</groupId>
93-
<artifactId>embedded-bookkeeper-core</artifactId>
94-
<version>${embedded-bookkeeper.version}</version>
95-
<scope>test</scope>
96-
</dependency>
97-
</dependencies>
98-
9946
<build>
10047
<sourceDirectory>${src.dir}</sourceDirectory>
10148
<plugins>

0 commit comments

Comments
 (0)