Skip to content

Commit 2b3450a

Browse files
zhangskzcopybara-github
authored andcommitted
Internal change
PiperOrigin-RevId: 847925916
1 parent 9eb9b36 commit 2b3450a

File tree

87 files changed

+507
-226
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

87 files changed

+507
-226
lines changed

.github/scripts/validate_yaml.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"""Validate the YAML files for GitHub Actions workflows.
22
3-
TODO: convert to use unittest
3+
TODO: b/359303016 - convert to use unittest
44
"""
55

66
import os

.github/workflows/test_cpp.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ jobs:
5959
- config: { name: "aarch64", flags: "--platforms=//build_defs:aarch64_linux" }
6060
cache_key: aarch64-bazel8
6161
targets: "//src/... //src/google/protobuf/compiler:protoc_aarch64_test //third_party/utf8_range/..."
62-
image: "us-docker.pkg.dev/protobuf-build/containers/test/linux/emulation:7.6.1-aarch64-f0d1e209ed9369f69d93ce418990ecff3aa08d6f" #TODO: upgrade to bazel 8
62+
image: "us-docker.pkg.dev/protobuf-build/containers/test/linux/emulation:7.6.1-aarch64-f0d1e209ed9369f69d93ce418990ecff3aa08d6f" #TODO: b/409557730 - upgrade to bazel 8
6363
name: ${{ matrix.config.continuous-only && inputs.continuous-prefix || '' }} Linux ${{ matrix.config.name }}
6464
runs-on: ${{ matrix.config.runner || 'ubuntu-latest' }}
6565
steps:
@@ -126,7 +126,7 @@ jobs:
126126
id: cross-compile
127127
uses: protocolbuffers/protobuf-ci/cross-compile-protoc@v5
128128
with:
129-
image: us-docker.pkg.dev/protobuf-build/containers/common/linux/bazel:7.6.1-e0df73e51131ccaf53451355d22577f377357604 #TODO: upgrade to bazel 8
129+
image: us-docker.pkg.dev/protobuf-build/containers/common/linux/bazel:7.6.1-e0df73e51131ccaf53451355d22577f377357604 #TODO: b/409557730 - upgrade to bazel 8
130130
credentials: ${{ secrets.GAR_SERVICE_ACCOUNT }}
131131
architecture: linux-${{ matrix.arch }}
132132
- name: Setup sccache

.github/workflows/test_csharp.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
with:
2424
ref: ${{ inputs.safe-checkout }}
2525

26-
# TODO(b/327464009) Run this with Bazel once codegen is handled properly.
26+
# TODO Run this with Bazel once codegen is handled properly.
2727
- name: Run tests
2828
uses: protocolbuffers/protobuf-ci/docker@v5
2929
with:

.github/workflows/test_java.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
- name: OpenJDK 8
3232
cache_key: '8'
3333
image: us-docker.pkg.dev/protobuf-build/containers/test/linux/java:8.0.1-8-b77fdae6d4771789dfc66a56bf8d806354e8011a
34-
# TODO: enable the layering check. Currently it does
34+
# TODO: b/318555165 - enable the layering check. Currently it does
3535
# not work correctly with the toolchain in this Docker image.
3636
targets: //java/... //java/internal:java_version --features=-layering_check
3737
flags: --java_language_version=8
@@ -53,7 +53,7 @@ jobs:
5353
image: us-docker.pkg.dev/protobuf-build/containers/common/linux/bazel:7.6.1-e0df73e51131ccaf53451355d22577f377357604
5454
targets: //java/... //java/internal:java_version //compatibility/...
5555
flags: --noenable_bzlmod
56-
# TODO: restore this test once runtime uses / emulates aarch64.
56+
# TODO: b/395623141 - restore this test once runtime uses / emulates aarch64.
5757
# - name: aarch64
5858
# cache_key: 'aarch64'
5959
# image: us-docker.pkg.dev/protobuf-build/containers/test/linux/emulation:7.6.1-aarch64-f0d1e209ed9369f69d93ce418990ecff3aa08d6f
@@ -76,7 +76,7 @@ jobs:
7676
bazel-cache: java_linux/${{ matrix.cache_key }}
7777
bazel: test ${{ matrix.targets }} ${{ matrix.flags }} --test_env=KOKORO_JAVA_VERSION
7878

79-
# TODO(b/311232187) restore this test (or a better one) when gRPC has rebuilt with 26.x
79+
# TODO restore this test (or a better one) when gRPC has rebuilt with 26.x
8080
# linkage-monitor:
8181
# name: Linux Linkage Monitor
8282
# runs-on: ubuntu-latest
@@ -91,7 +91,7 @@ jobs:
9191
# image: us-docker.pkg.dev/protobuf-build/containers/test/linux/java:8-1fdbb997433cb22c1e49ef75ad374a8d6bb88702
9292
# credentials: ${{ secrets.GAR_SERVICE_ACCOUNT }}
9393
# bazel-cache: java_linux/8
94-
# # TODO: enable the layering check. Currently it does
94+
# # TODO: b/318555165 - enable the layering check. Currently it does
9595
# # not work correctly with the toolchain in this Docker image.
9696
# bazel: test --test_output=all //java:linkage_monitor --spawn_strategy=standalone --features=-layering_check
9797

.github/workflows/test_php.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ jobs:
115115
id: cross-compile
116116
uses: protocolbuffers/protobuf-ci/cross-compile-protoc@v5
117117
with:
118-
image: us-docker.pkg.dev/protobuf-build/containers/common/linux/bazel:7.6.1-e0df73e51131ccaf53451355d22577f377357604 #TODO: upgrade to bazel 8.0.1
118+
image: us-docker.pkg.dev/protobuf-build/containers/common/linux/bazel:7.6.1-e0df73e51131ccaf53451355d22577f377357604 #TODO: b/409557730 - upgrade to bazel 8.0.1
119119
credentials: ${{ secrets.GAR_SERVICE_ACCOUNT }}
120120
architecture: linux-i386
121121

@@ -147,7 +147,7 @@ jobs:
147147
id: cross-compile
148148
uses: protocolbuffers/protobuf-ci/cross-compile-protoc@v5
149149
with:
150-
image: us-docker.pkg.dev/protobuf-build/containers/common/linux/bazel:7.6.1-e0df73e51131ccaf53451355d22577f377357604 #TODO: upgrade to bazel 8.0.1
150+
image: us-docker.pkg.dev/protobuf-build/containers/common/linux/bazel:7.6.1-e0df73e51131ccaf53451355d22577f377357604 #TODO: b/409557730 - upgrade to bazel 8.0.1
151151
credentials: ${{ secrets.GAR_SERVICE_ACCOUNT }}
152152
architecture: linux-aarch64
153153

@@ -205,7 +205,7 @@ jobs:
205205
with:
206206
credentials: ${{ secrets.GAR_SERVICE_ACCOUNT }}
207207
bazel-version: 8.0.1
208-
# TODO(b/467211650) this shouldn't be necessary, remove it
208+
# TODO this shouldn't be necessary, remove it
209209
bazel-flags: --xcode_version_config=//.github:host_xcodes_macos15
210210
command: |
211211
pushd php

.github/workflows/test_python.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
- type: C++
5353
version: aarch64
5454
targets: //python/... //python:aarch64_test
55-
# TODO(b/262628111) Enable this once conformance tests are fixed.
55+
# TODO Enable this once conformance tests are fixed.
5656
flags: --define=use_fast_cpp_protos=true --test_tag_filters=-conformance
5757
image: us-docker.pkg.dev/protobuf-build/containers/test/linux/emulation:7.6.1-aarch64-f0d1e209ed9369f69d93ce418990ecff3aa08d6f
5858

.github/workflows/test_ruby.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ jobs:
7777
id: cross-compile
7878
uses: protocolbuffers/protobuf-ci/cross-compile-protoc@v5
7979
with:
80-
image: us-docker.pkg.dev/protobuf-build/containers/common/linux/bazel:7.6.1-e0df73e51131ccaf53451355d22577f377357604 #TODO: upgrade to bazel 8.0.1
80+
image: us-docker.pkg.dev/protobuf-build/containers/common/linux/bazel:7.6.1-e0df73e51131ccaf53451355d22577f377357604 #TODO: b/409557730 - upgrade to bazel 8.0.1
8181
credentials: ${{ secrets.GAR_SERVICE_ACCOUNT }}
8282
architecture: linux-i386
8383

@@ -110,7 +110,7 @@ jobs:
110110
id: cross-compile
111111
uses: protocolbuffers/protobuf-ci/cross-compile-protoc@v5
112112
with:
113-
image: us-docker.pkg.dev/protobuf-build/containers/common/linux/bazel:7.6.1-e0df73e51131ccaf53451355d22577f377357604 #TODO: upgrade to bazel 8.0.1
113+
image: us-docker.pkg.dev/protobuf-build/containers/common/linux/bazel:7.6.1-e0df73e51131ccaf53451355d22577f377357604 #TODO: b/409557730 - upgrade to bazel 8.0.1
114114
credentials: ${{ secrets.GAR_SERVICE_ACCOUNT }}
115115
architecture: linux-aarch64
116116

ci/common.bazelrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ build:dbg --compilation_mode=dbg
66
build:opt --compilation_mode=opt
77

88
build:san-common --config=dbg --strip=never --copt=-O1 --copt=-fno-omit-frame-pointer
9-
# TODO(b/392921707) ASAN hits ODR violations with shared linkage due to
9+
# TODO ASAN hits ODR violations with shared linkage due to
1010
# cc_proto_library cyclic dependency.
1111
build:san-common --dynamic_mode=off
1212

cmake/upb_generators.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ foreach(generator upb upbdefs upb_minitable)
1818
protobuf_configure_target(protoc-gen-${generator})
1919
target_include_directories(protoc-gen-${generator} PRIVATE ${bootstrap_cmake_dir})
2020
if(protobuf_BUILD_SHARED_LIBS)
21-
# TODO(b/419096242) These binaries should depend on libprotoc.
21+
# TODO These binaries should depend on libprotoc.
2222
target_compile_definitions(protoc-gen-${generator}
2323
PRIVATE LIBPROTOC_EXPORTS PROTOBUF_USE_DLLS)
2424
endif()

conformance/testee.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
// .SerializeText({.print_unknown_fields = true}),
2828
// ParsedPayload(EqualsProto("pb(1: "foo")pb")));
2929

30-
// TODO(b/410123876) Possible future APIs to expand conformance coverage:
30+
// TODO Possible future APIs to expand conformance coverage:
3131
// - Add ClearUnknownFields() to InMemoryMessage
3232
// - Add MergeFrom() method to InMemoryMessage to merge raw binary
3333
// - Remove && qualifiers on Parse* and add InMemoryMessage::Merge that merges

0 commit comments

Comments
 (0)