Update Roads.java: exclude 'platform_edge' from railways#547
Update Roads.java: exclude 'platform_edge' from railways#547bdon merged 6 commits intoprotomaps:mainfrom
Conversation
migurski
left a comment
There was a problem hiding this comment.
This change looks good, really appreciate it. Would you be able to address the linter feedback so it can be merged?
|
Adding a render test here: pietervdvn#1 |
Add render test for railway platform edge
|
|
I've addressed the linter feedback, but, to be a bit blunt: why bother? The tooling can do this fully automatically. IMHO, automatically linting/formatting the codebase every now and then can be done with a script without having to do another round of feedback to me. (For context: I simply made the changes in the web editor without setting up the dev environment) |
|
I've also merged (and fixed) in the render test by @wipfli |
You can run |
This implies that I installed the entire toolchain (spoilers: I didn't) and that I know this (spoilers: I didn't). This adds some more friction to the process of contributing here, which IMHO is useless. Just my 2 cents though. Anyway, thanks for merging in my request and for maintining protomaps! |


Apparently, some people add the edge of platforms into OpenStreetMap.
This was picked up as "railway", giving extra railways renderings where there are none (the two "dead end" railways should dissappear):
This PR excludes them from tile generation