Change the behavior of Form.serialize to match the earlier changes to Hash#toQueryString.

Newlines are normalized and spaces are converted to `+` instead of `%20`. One day I'll centralize this logic so we don't have to do this in two places.

Author: savetheclocktower

src/prototype/dom/form.js

@@ -120,7 +120,14 @@ var Form = {
     } else {
       initial = '';
       accumulator = function(result, key, value) {
-        return result + (result ? '&' : '') + encodeURIComponent(key) + '=' + encodeURIComponent(value);
+        // Normalize newlines as \r\n because the HTML spec says newlines should
+        // be encoded as CRLFs.
+        value = value.gsub(/(\r)?\n/, '\r\n');
+        value = encodeURIComponent(value);
+        // Likewise, according to the spec, spaces should be '+' rather than
+        // '%20'.
+        value = value.gsub(/%20/, '+');
+        return result + (result ? '&' : '') + encodeURIComponent(key) + '=' + value;
       }
     }
 

test/unit/form_test.js

@@ -257,10 +257,10 @@ new Test.Unit.Runner({
     };
 
     // return params
-    this.assertHashEqual(expected, Form.serialize('various', true));
+    this.assertHashEqual(expected, Form.serialize('various', true), "test the whole form (as a hash)");
     // return string
     this.assertEnumEqual(Object.toQueryString(expected).split('&').sort(),
-                    Form.serialize('various').split('&').sort());
+                    Form.serialize('various').split('&').sort(), "test the whole form (as a string)");
     this.assertEqual('string', typeof $('form').serialize({ hash:false }));
 
     // Checks that disabled element is not included in serialized form.