Fix some async tests.

These weren’t being handled as async tests even though they do async stuff. Any failures in these tests were being thrown but not caught; in most browsers this just displays an error, but in IE 6-7 it caused everything to get out of whack. Subsequent tests would run at the wrong time and would fail because they didn’t see the HTML fixtures they were expecting.

Author: savetheclocktower

test.new/tests/function.test.js

@@ -111,7 +111,7 @@ suite('Function', function () {
     assert.strictEqual(split, split.curry());
   });
 
-  test('#delay', function () {
+  test('#delay', function (done) {
     window.delayed = undefined;
     var delayedFunction = function() { window.delayed = true; };
     var delayedFunctionWithArgs = function() { window.delayedWithArgs = $A(arguments).join(' '); };
@@ -121,6 +121,7 @@ suite('Function', function () {
     wait(1000, function() {
       assert(window.delayed);
       assert.equal('hello world', window.delayedWithArgs);
+      done();
     });
   });
 
@@ -146,7 +147,7 @@ suite('Function', function () {
     String.prototype.capitalize = temp;
   });
 
-  test('#defer', function () {
+  test('#defer', function (done) {
     window.deferred = undefined;
     var deferredFunction = function() { window.deferred = true; };
     deferredFunction.defer();
@@ -180,6 +181,7 @@ suite('Function', function () {
 
           wait(50, function() {
             assert(window.deferBoundProperlyOnString);
+            done();
           });
         });
       });

test.new/tests/layout.test.js

@@ -387,7 +387,8 @@ suite("Layout",function(){
 
   suite('document.viewport', function () {
 
-    test('#getDimensions', function () {
+    test('#getDimensions', function (done) {
+      this.timeout(5000);
       var original = document.viewport.getDimensions();
 
       try {
@@ -404,13 +405,14 @@ suite("Layout",function(){
 
         window.resizeBy(50, 50);
         wait(1000, function() {
-          var after  = document.viewport.getDimensions();
+          var after = document.viewport.getDimensions();
 
           // Assume that JavaScript window resizing is disabled if before width
           // and after width are the same.
           if (before.width === after.width) {
             RESIZE_DISABLED = true;
             info("SKIPPING REMAINING TESTS (JavaScript window resizing disabled)");
+            done();
             return;
           }
 
@@ -429,6 +431,7 @@ suite("Layout",function(){
               original.width  + delta.width,
               original.height + delta.height
             );
+            done();
           });
         });
       });
@@ -449,7 +452,8 @@ suite("Layout",function(){
       });
     });
 
-    test('#getScrollOffsets', function () {
+    test('#getScrollOffsets', function (done) {
+      this.timeout(5000);
       var original = document.viewport.getDimensions();
 
       window.scrollTo(0, 0);
@@ -479,6 +483,7 @@ suite("Layout",function(){
             original.width  + delta.width,
             original.height + delta.height
           );
+          done();
         });
       });
     });

test.new/tests/periodical_executer.test.js

@@ -2,7 +2,7 @@
 suite('PeriodicalExecuter', function () {
   this.name = 'periodical_executer';
 
-  test('#stop', function () {
+  test('#stop', function (done) {
     var peEventCount = 0;
     function peEventFired(pe) {
       if (++peEventCount > 2) pe.stop();
@@ -13,6 +13,7 @@ suite('PeriodicalExecuter', function () {
 
     wait(600, function() {
       assert.equal(3, peEventCount);
+      done();
     });
   });