Skip to content

Commit 9d49b1b

Browse files
Change failing tests.
One of these tests presumably tests comma handling — whether we do the right thing when the space is before the comma, or when there end up being duplicate commas — and this is not something we handled before, so if this is a newly-failing test it's because Sizzle used to handle this and now does not. That's fine with me. The other one appears to be a disagreement over whether `:enabled` should match `input[type=hidden]`, and Sizzle apparently says it does, and I'm OK with that, too.
1 parent 2154799 commit 9d49b1b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/unit/selector_test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ new Test.Unit.Runner({
285285

286286
testSelectorWithEnabledDisabledChecked: function() {
287287
this.assertEnumEqual([$('disabled_text_field')], $$('#troubleForm > *:disabled'), ':disabled');
288-
this.assertEnumEqual($('troubleForm').getInputs().without($('disabled_text_field'), $('hidden')), $$('#troubleForm > *:enabled'), ':enabled');
288+
this.assertEnumEqual($('troubleForm').getInputs().without($('disabled_text_field')), $$('#troubleForm > *:enabled'), ':enabled');
289289
this.assertEnumEqual($('checked_box', 'checked_radio'), $$('#troubleForm *:checked'), ':checked');
290290
},
291291

@@ -319,8 +319,8 @@ new Test.Unit.Runner({
319319
},
320320

321321
testCommasFor$$: function() {
322-
this.assertEnumEqual($('p', 'link_1', 'list', 'item_1', 'item_3', 'troubleForm'), $$('#list, .first,#item_3 , #troubleForm'));
323-
this.assertEnumEqual($('p', 'link_1', 'list', 'item_1', 'item_3', 'troubleForm'), $$('#list, .first,', '#item_3 , #troubleForm'));
322+
this.assertEnumEqual($('p', 'link_1', 'list', 'item_1', 'item_3', 'troubleForm'), $$('#list, .first, #item_3, #troubleForm'));
323+
this.assertEnumEqual($('p', 'link_1', 'list', 'item_1', 'item_3', 'troubleForm'), $$('#list, .first', '#item_3, #troubleForm'));
324324
this.assertEnumEqual($('commaParent', 'commaChild'), $$('form[title*="commas,"], input[value="#commaOne,#commaTwo"]'));
325325
this.assertEnumEqual($('commaParent', 'commaChild'), $$('form[title*="commas,"]', 'input[value="#commaOne,#commaTwo"]'));
326326
},

0 commit comments

Comments
 (0)