Skip to content

include perf boost as well as ECMA6 detect for include or contains #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

include perf boost as well as ECMA6 detect for include or contains #105

wants to merge 1 commit into from

Conversation

jwestbrook
Copy link
Collaborator

Based on the proposed polyfill for ECMA6 for String.prototype.contains()

http://wiki.ecmascript.org/doku.php?id=harmony:string_extras

using not equivalent to !== instead of greater than > gets a performance boost according to
http://jsperf.com/string-contains

as well as add the detection if String.prototype.contains() exists then map include() to that

@jwestbrook
Copy link
Collaborator Author

@savetheclocktower Any possibility of getting this PR merged in?

codemasher added a commit to codemasher/prototype that referenced this pull request Mar 2, 2021
@codemasher
🚿 map String.prototype.contains to String.include() (prototypejs#105)
aa2cec3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwestbrook @savetheclocktower