Added new method for Object class, Object #isObject #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. Maybe. Leaving this open for now so I can revisit it in a future version; next release will be a bugfix release. |
|
Closing because we're removing support for IE 8 and below. |
|
Whoops, wrong PR. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short explanation why I added this API.
I wrote a function which can process the request with variable arguments
case A : arg0 -> property, arg1 -> value
or
case B : arg0 -> {properties : values}
So for the case (B), I need to make sure the param is only of type Object else the results will be odd.
Because in javascript
for inloop can loop overstringby creating properties 0, 1, 2... for each character the string contains and also over String class properties.Also most of the utility functions we write takes options/params parameter, which is an object (mostly containing flags) to add additional functionality for any utility. So looping over the options/params will be error free, if we make sure the param is Object type.
This will also eliminates null check for options because if the parameter is null/undefined Object.isObject(null) returns false.