Added html5data methods set/get #91
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the issue below sethtml5data() and gethtml5data() will write to the dataset and the write the data-* attributes correctly in any browsers that Prototype supports. https://prototype.lighthouseapp.com/projects/8886/tickets/250-support-for-dataset-property-and-data-attributes
| //simple test for native HTML5 dataset existence | ||
| var NATIVEHTML5DATASET = (function (){ | ||
| var testelement = new Element("div",{"data-test-this-thing":"test"}); | ||
| if(typeof testelement.dataset != 'undefined' && typeof testelement.dataset.testThisThing != 'undefined') return true; |
There was a problem hiding this comment.
return (testelement.dataset && testelement.dataset.testThisThing === 'test');
Separated out native vs simulated HTML5 dataset usage and fixed up the test to see if native was available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the issue below
sethtml5data()andgethtml5data()will write tothe dataset and the write the data-* attributes correctly in any
browsers that Prototype supports.
https://prototype.lighthouseapp.com/projects/8886/tickets/250-support-for-dataset-property-and-data-attributes