Skip to content

Commit 62f4778

Browse files
authored
Fix dropdown jump effect bug on mouse over in topics list (#1875)
* fix dropdown jump effect bug on mouse over in topics list * fix isHidden condition
1 parent 4c76d07 commit 62f4778

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

kafka-ui-react-app/src/components/Topics/List/List.styled.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,5 @@ export const Link = styled(NavLink).attrs({ activeClassName: 'is-active' })<{
2424

2525
export const ActionsTd = styled(Td)`
2626
overflow: visible;
27+
width: 50px;
2728
`;

kafka-ui-react-app/src/components/Topics/List/List.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,8 @@ const List: React.FC<TopicsListProps> = ({
185185
setRecreateTopicConfirmationVisible,
186186
] = React.useState(false);
187187

188+
const isHidden = internal || isReadOnly || !hovered;
189+
188190
const deleteTopicHandler = React.useCallback(() => {
189191
deleteTopic(clusterName, name);
190192
}, [name]);
@@ -200,8 +202,8 @@ const List: React.FC<TopicsListProps> = ({
200202

201203
return (
202204
<>
203-
{!internal && !isReadOnly && hovered ? (
204-
<div className="has-text-right">
205+
<div className="has-text-right">
206+
{!isHidden && (
205207
<Dropdown label={<VerticalElipsisIcon />} right>
206208
{cleanUpPolicy === CleanUpPolicy.DELETE && (
207209
<DropdownItem onClick={clearTopicMessagesHandler} danger>
@@ -223,8 +225,8 @@ const List: React.FC<TopicsListProps> = ({
223225
Recreate Topic
224226
</DropdownItem>
225227
</Dropdown>
226-
</div>
227-
) : null}
228+
)}
229+
</div>
228230
<ConfirmationModal
229231
isOpen={isDeleteTopicConfirmationVisible}
230232
onCancel={() => setDeleteTopicConfirmationVisible(false)}

0 commit comments

Comments
 (0)