-
Notifications
You must be signed in to change notification settings - Fork 35
Open
Labels
Description
resolve_trades currently only works when there is exactly one Buy and one Sell op for any particular utc_time.
This leaves many cases unhandled, which could result in miscalculated gains.
Here are four such cases:
- Multiple buy/sell-pairs at a particular
utc_time - Orders not being fulfilled at once, leading to
Buy/Sellops later on. - Commissions / Withdrawals / Deposits / Airdrop / CoinLendInterest increasing the op count (more than 2 ops in that case)
- It can happen that bnb small asset exchange happen at multiple
utc_times (sell ops one second before buy ops)
The first case can be resolved for 3 coins if there is a "bridge coin" (sell btc -> usdt, buy eth -> usdt), because usdt is included in both orders.
The third case can be resolved by filtering the irrelevant ops.
Binance does provide an order history, which contains the required information to resolve trades correctly, even when multiple trades occur. Maybe that can help us.
pr: #136
Reactions are currently unavailable