chore: dict_dump_xml needs to raise an exception when it fails

Author: provos

src/planai/utils.py

@@ -84,18 +84,13 @@ def model_dump_xml(self, root: str = "root"):
 
 def dict_dump_xml(dict: Dict[Any, Any], root: str = "root") -> str:
     """Formats the task as XML."""
-    try:
-        xml = dicttoxml.dicttoxml(dict, custom_root=root, attr_type=False)
-        # Decode bytes to string with utf-8 encoding
-        xml_str = xml.decode("utf-8")
-        xml_string = parseString(xml_str).toprettyxml(indent="  ")
-        # Remove the XML declaration efficiently
-        if xml_string.startswith("<?xml"):
-            newline_index = xml_string.find("\n")
-            if newline_index != -1:
-                xml_string = xml_string[(newline_index + 1) :]
-        return xml_string
-    except Exception as e:
-        logging.error(f"Failed to convert dictionary to XML: {e}")
-        # Return a simple valid XML as fallback
-        return f"<{root}><error>Failed to convert to XML</error></{root}>"
+    xml = dicttoxml.dicttoxml(dict, custom_root=root, attr_type=False)
+    # Decode bytes to string with utf-8 encoding
+    xml_str = xml.decode("utf-8")
+    xml_string = parseString(xml_str).toprettyxml(indent="  ")
+    # Remove the XML declaration efficiently
+    if xml_string.startswith("<?xml"):
+        newline_index = xml_string.find("\n")
+        if newline_index != -1:
+            xml_string = xml_string[(newline_index + 1) :]
+    return xml_string

tests/planai/test_utils.py

@@ -49,22 +49,6 @@ def test_complex_types(self):
         self.assertIn("<bytes>", result)
         self.assertIn("<set>", result)
 
-    def test_invalid_input(self):
-        test_cases = [
-            ("Function value", {"func": lambda x: x}),
-            ("Circular reference", {}),
-        ]
-
-        # Create circular reference
-        d = test_cases[1][1]
-        d["circular"] = d
-
-        for case_name, test_dict in test_cases:
-            with self.subTest(case_name=case_name):
-                result = dict_dump_xml(test_dict)
-                self.assertIsInstance(result, str)
-                self.assertIn("<error>Failed to convert to XML</error>", result)
-
     def test_custom_root(self):
         test_dict = {"key": "value"}
         result = dict_dump_xml(test_dict, root="custom")
@@ -82,6 +66,12 @@ def test_unicode_keys(self):
         self.assertIn("<키>값</키>", result)
         self.assertIn("<ключ>значение</ключ>", result)
 
+    def test_random_bytes(self):
+        test_dict = {"random": b"\x00\x01\x02\x03\x04\x05\x06\x07\x08\x09"}
+        result = dict_dump_xml(test_dict)
+        self.assertIn("<random>", result)
+        self.assertIn("</random>", result)
+
 
 if __name__ == "__main__":
     unittest.main()