Skip to content

Commit 008c46d

Browse files
committed
Added no-op implementations of warm() to other subclasses of WasmVm
Signed-off-by: Rachel Green <[email protected]>
1 parent 158d7bf commit 008c46d

File tree

3 files changed

+8
-0
lines changed

3 files changed

+8
-0
lines changed

src/wamr/wamr.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,8 @@ class Wamr : public WasmVm {
8989

9090
void terminate() override {}
9191
bool usesWasmByteOrder() override { return true; }
92+
93+
void warm() override {}
9294

9395
private:
9496
template <typename... Args>

src/wasmedge/wasmedge.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,7 @@ class WasmEdge : public WasmVm {
264264
};
265265
FOR_ALL_WASM_VM_EXPORTS(_GET_MODULE_FUNCTION)
266266
#undef _GET_MODULE_FUNCTION
267+
267268
private:
268269
template <typename... Args>
269270
void registerHostFunctionImpl(std::string_view module_name, std::string_view function_name,
@@ -284,6 +285,8 @@ class WasmEdge : public WasmVm {
284285
void terminate() override {}
285286
bool usesWasmByteOrder() override { return true; }
286287

288+
void warm() override {}
289+
287290
WasmEdgeLoaderPtr loader_;
288291
WasmEdgeValidatorPtr validator_;
289292
WasmEdgeExecutorPtr executor_;

src/wasmtime/wasmtime.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ class Wasmtime : public WasmVm {
8080
};
8181
FOR_ALL_WASM_VM_EXPORTS(_GET_MODULE_FUNCTION)
8282
#undef _GET_MODULE_FUNCTION
83+
8384
private:
8485
template <typename... Args>
8586
void registerHostFunctionImpl(std::string_view module_name, std::string_view function_name,
@@ -100,6 +101,8 @@ class Wasmtime : public WasmVm {
100101
void terminate() override {}
101102
bool usesWasmByteOrder() override { return true; }
102103

104+
void warm() override {}
105+
103106
WasmStorePtr store_;
104107
WasmModulePtr module_;
105108
WasmSharedModulePtr shared_module_;

0 commit comments

Comments
 (0)