Skip to content

Commit aeec322

Browse files
committed
nit fixes
Signed-off-by: Rachel Green <[email protected]>
1 parent 207dd5f commit aeec322

File tree

1 file changed

+12
-15
lines changed

1 file changed

+12
-15
lines changed

include/proxy-wasm/wasm_vm.h

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,17 @@ enum class AbiVersion { ProxyWasm_0_1_0, ProxyWasm_0_2_0, ProxyWasm_0_2_1, Unkno
143143

144144
class NullPlugin;
145145

146+
enum class FailState : int {
147+
Ok = 0,
148+
UnableToCreateVm = 1,
149+
UnableToCloneVm = 2,
150+
MissingFunction = 3,
151+
UnableToInitializeCode = 4,
152+
StartFailed = 5,
153+
ConfigureFailed = 6,
154+
RuntimeError = 7,
155+
};
156+
146157
// Integrator specific WasmVm operations.
147158
struct WasmVmIntegration {
148159
virtual ~WasmVmIntegration() {}
@@ -167,17 +178,6 @@ struct WasmVmIntegration {
167178
void *ptr_to_function_return) = 0;
168179
};
169180

170-
enum class FailState : int {
171-
Ok = 0,
172-
UnableToCreateVm = 1,
173-
UnableToCloneVm = 2,
174-
MissingFunction = 3,
175-
UnableToInitializeCode = 4,
176-
StartFailed = 5,
177-
ConfigureFailed = 6,
178-
RuntimeError = 7,
179-
};
180-
181181
// Wasm VM instance. Provides the low level WASM interface.
182182
class WasmVm {
183183
public:
@@ -310,10 +310,7 @@ class WasmVm {
310310
*/
311311
virtual bool usesWasmByteOrder() = 0;
312312

313-
/**
314-
* Warm the VM such as engine and runtime.
315-
*/
316-
virtual void warm() = 0;
313+
virtual void warm() {}
317314

318315
bool isFailed() { return failed_ != FailState::Ok; }
319316
void fail(FailState fail_state, std::string_view message) {

0 commit comments

Comments
 (0)