chore: Silence tsan warnings inside V8

These warnings flag a Join() function protected by a mutex. Such a function marks that the racy operation has ended.

Signed-off-by: Matt Leon <[email protected]>

Author: leonm1

.bazelrc

@@ -55,6 +55,7 @@ build:clang-tsan --config=clang-xsan
 build:clang-tsan --copt -DTHREAD_SANITIZER=1
 build:clang-tsan --copt -fsanitize=thread
 build:clang-tsan --linkopt -fsanitize=thread
+build:clang-tsan --test_env=TSAN_OPTIONS=suppressions=bazel/tsan_suppressions.txt
 
 # Use Clang-Tidy tool.
 build:clang-tidy --config=clang

bazel/BUILD

@@ -68,3 +68,5 @@ selects.config_setting_group(
         ":linux_s390x",
     ],
 )
+
+exports_files(["tsan_suppressions.txt"])

bazel/cc_defs.bzl

@@ -0,0 +1,9 @@
+load("@rules_cc//cc:defs.bzl", _cc_test = "cc_test")
+load("@rules_fuzzing//fuzzing:cc_defs.bzl", _cc_fuzz_test = "cc_fuzz_test")
+
+def cc_test(data=[], **kwargs):
+  _cc_test(data = data + ['//bazel:tsan_suppressions.txt'], **kwargs)
+
+def cc_fuzz_test(data=[], **kwargs):
+  _cc_fuzz_test(data = data + ['//bazel:tsan_suppressions.txt'], **kwargs)
+

bazel/tsan_suppressions.txt

@@ -0,0 +1,2 @@
+# False positive in V8 worker shutdown
+race:v8::platform::DefaultJobHandle::Join

test/BUILD

@@ -13,7 +13,8 @@
 # limitations under the License.
 
 load("@proxy_wasm_cpp_host//bazel:select.bzl", "proxy_wasm_select_engine_null")
-load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
+load("@rules_cc//cc:defs.bzl", "cc_library")
+load("//bazel:cc_defs.bzl", "cc_test")
 
 licenses(["notice"])  # Apache 2
 

test/fuzz/BUILD

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-load("@rules_fuzzing//fuzzing:cc_defs.bzl", "cc_fuzz_test")
+load("//bazel:cc_defs.bzl", "cc_fuzz_test")
 
 licenses(["notice"])  # Apache 2