1
1
# 1. Disable pointer compression (limits the maximum number of WasmVMs).
2
2
# 2. Don't expose Wasm C API (only Wasm C++ API).
3
- # 3. Fix gcc build error by disabling nonnull warning.
4
- # 4. Allow compiling v8 on macOS 10.15 to 13.0. TODO(dio): Will remove this patch when https://bugs.chromium.org/p/v8/issues/detail?id=13428 is fixed.
5
3
6
4
diff --git a/BUILD.bazel b/BUILD.bazel
7
- index 4e89f90e7e..3fcb38b3f3 100644
5
+ index 30be47fa333..d03d1e4d522 100644
8
6
--- a/BUILD.bazel
9
7
+++ b/BUILD.bazel
10
- @@ -157 ,7 +157 ,7 @@ v8_int(
8
+ @@ -220 ,7 +220 ,7 @@ v8_int(
11
9
# If no explicit value for v8_enable_pointer_compression, we set it to 'none'.
12
10
v8_string(
13
11
name = "v8_enable_pointer_compression",
@@ -16,42 +14,11 @@ index 4e89f90e7e..3fcb38b3f3 100644
16
14
)
17
15
18
16
# Default setting for v8_enable_pointer_compression.
19
- diff --git a/bazel/defs.bzl b/bazel/defs.bzl
20
- index e957c0fad3..063627b72b 100644
21
- --- a/bazel/defs.bzl
22
- +++ b/bazel/defs.bzl
23
- @@ -131,6 +131,7 @@ def _default_args():
24
- "-Wno-redundant-move",
25
- "-Wno-return-type",
26
- "-Wno-stringop-overflow",
27
- + "-Wno-nonnull",
28
- # Use GNU dialect, because GCC doesn't allow using
29
- # ##__VA_ARGS__ when in standards-conforming mode.
30
- "-std=gnu++17",
31
- @@ -151,6 +152,18 @@ def _default_args():
32
- "-fno-integrated-as",
33
- ],
34
- "//conditions:default": [],
35
- + }) + select({
36
- + "@v8//bazel/config:is_macos": [
37
- + # The clang available on macOS catalina has a warning that isn't clean on v8 code.
38
- + "-Wno-range-loop-analysis",
39
- +
40
- + # To supress warning on deprecated declaration on v8 code. For example:
41
- + # external/v8/src/base/platform/platform-darwin.cc:56:22: 'getsectdatafromheader_64'
42
- + # is deprecated: first deprecated in macOS 13.0.
43
- + # https://bugs.chromium.org/p/v8/issues/detail?id=13428.
44
- + "-Wno-deprecated-declarations",
45
- + ],
46
- + "//conditions:default": [],
47
- }),
48
- includes = ["include"],
49
- linkopts = select({
50
17
diff --git a/src/wasm/c-api.cc b/src/wasm/c-api.cc
51
- index 4473e205c0..65a6ec7e1d 100644
18
+ index 2d6d0f6c270..61d071acd52 100644
52
19
--- a/src/wasm/c-api.cc
53
20
+++ b/src/wasm/c-api.cc
54
- @@ -2247 ,6 +2247 ,8 @@ auto Instance::exports() const -> ownvec<Extern> {
21
+ @@ -2360 ,6 +2360 ,8 @@ auto Instance::exports() const -> ownvec<Extern> {
55
22
56
23
} // namespace wasm
57
24
@@ -60,7 +27,7 @@ index 4473e205c0..65a6ec7e1d 100644
60
27
// BEGIN FILE wasm-c.cc
61
28
62
29
extern "C" {
63
- @@ -3274 ,3 +3276 ,5 @@ wasm_instance_t* wasm_frame_instance(const wasm_frame_t* frame) {
30
+ @@ -3386 ,3 +3388 ,5 @@ wasm_instance_t* wasm_frame_instance(const wasm_frame_t* frame) {
64
31
#undef WASM_DEFINE_SHARABLE_REF
65
32
66
33
} // extern "C"
0 commit comments