Skip to content

Commit ed21050

Browse files
committed
Fix crates_vendor to work with wasmsign (and wasmsign2) binaries
Signed-off-by: Martijn Stevenson <[email protected]>
1 parent ddfb7c3 commit ed21050

File tree

5 files changed

+54
-2
lines changed

5 files changed

+54
-2
lines changed

bazel/cargo/wasmsign/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ exports_files(
2626
crates_vendor(
2727
name = "crates_vendor",
2828
cargo_lockfile = "//bazel/cargo/wasmsign:Cargo.Bazel.lock",
29+
generate_binaries = True,
2930
generate_target_compatible_with = False,
3031
manifests = ["//bazel/cargo/wasmsign:Cargo.toml"],
3132
mode = "remote",

bazel/cargo/wasmsign/Cargo.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,7 @@ path = "fake_lib.rs"
88

99
[dependencies]
1010
wasmsign = {git = "https://github.com/jedisct1/wasmsign", revision = "fa4d5598f778390df09be94232972b5b865a56b8"}
11+
12+
# Ready to upgrade to wasmsign2:
13+
# Which generates: //bazel/cargo/wasmsign/remote:wasmsign2-cli__wasmsign2
14+
#wasmsign2-cli = {git = "https://github.com/wasm-signatures/wasmsign2", revision = "07c60eee7f4c655d5a91404f5a9ffd97316d01f1"}

bazel/cargo/wasmsign/remote/BUILD.bazel

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,10 @@ alias(
3030
actual = "@crates_vendor__wasmsign-0.1.2//:wasmsign",
3131
tags = ["manual"],
3232
)
33+
34+
# Binaries
35+
alias(
36+
name = "wasmsign__wasmsign",
37+
actual = "@crates_vendor__wasmsign-0.1.2//:wasmsign__bin",
38+
tags = ["manual"],
39+
)

bazel/cargo/wasmsign/remote/BUILD.wasmsign-0.1.2.bazel

Lines changed: 41 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@
66
# bazel run //bazel/cargo/wasmsign:crates_vendor
77
###############################################################################
88

9-
load("@rules_rust//rust:defs.bzl", "rust_library")
9+
load(
10+
"@rules_rust//rust:defs.bzl",
11+
"rust_binary",
12+
"rust_library",
13+
)
1014

1115
package(default_visibility = ["//visibility:public"])
1216

@@ -44,3 +48,39 @@ rust_library(
4448
"@crates_vendor__thiserror-1.0.63//:thiserror",
4549
],
4650
)
51+
52+
rust_binary(
53+
name = "wasmsign__bin",
54+
srcs = glob(["**/*.rs"]),
55+
compile_data = glob(
56+
include = ["**"],
57+
exclude = [
58+
"**/* *",
59+
"BUILD",
60+
"BUILD.bazel",
61+
"WORKSPACE",
62+
"WORKSPACE.bazel",
63+
],
64+
),
65+
crate_root = "src/bin/wasmsign.rs",
66+
edition = "2018",
67+
rustc_flags = ["--cap-lints=allow"],
68+
tags = [
69+
"cargo-bazel",
70+
"crate-name=wasmsign",
71+
"manual",
72+
"noclippy",
73+
"norustfmt",
74+
],
75+
version = "0.1.2",
76+
deps = [
77+
":wasmsign",
78+
"@crates_vendor__anyhow-1.0.86//:anyhow",
79+
"@crates_vendor__byteorder-1.5.0//:byteorder",
80+
"@crates_vendor__clap-2.34.0//:clap",
81+
"@crates_vendor__ed25519-compact-1.0.16//:ed25519_compact",
82+
"@crates_vendor__hmac-sha512-1.1.5//:hmac_sha512",
83+
"@crates_vendor__parity-wasm-0.42.2//:parity_wasm",
84+
"@crates_vendor__thiserror-1.0.63//:thiserror",
85+
],
86+
)

bazel/wasm.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def _wasm_attrs(transition):
6363
return {
6464
"binary": attr.label(mandatory = True, cfg = transition),
6565
"signing_key": attr.label_list(allow_files = True),
66-
"_wasmsign_tool": attr.label(default = "//bazel/cargo/wasmsign/remote:wasmsign", executable = True, cfg = "exec"),
66+
"_wasmsign_tool": attr.label(default = "//bazel/cargo/wasmsign/remote:wasmsign__wasmsign", executable = True, cfg = "exec"),
6767
"_whitelist_function_transition": attr.label(default = "@bazel_tools//tools/whitelists/function_transition_whitelist"),
6868
}
6969

0 commit comments

Comments
 (0)