Inquiry about the Transfer of OnStreamDone and OnHttpStreamDone from proxyOnDone to proxyOnLog

[007gzs]

proxy-wasm-go-sdk/proxywasm/internal/abi_callback_lifecycle.go

Lines 36 to 59 in ab4161d

	func proxyOnLog(contextID uint32) {
	if recordTiming {
	defer logTiming("proxyOnLog", time.Now())
	}
	if ctx, ok := currentState.tcpContexts[contextID]; ok {
	currentState.setActiveContextID(contextID)
	ctx.OnStreamDone()
	} else if ctx, ok := currentState.httpContexts[contextID]; ok {
	currentState.setActiveContextID(contextID)
	ctx.OnHttpStreamDone()
	}
	}
	//go:wasmexport proxy_on_done
	func proxyOnDone(contextID uint32) bool {
	if recordTiming {
	defer logTiming("proxyOnDone", time.Now())
	}
	if ctx, ok := currentState.pluginContexts[contextID]; ok {
	currentState.setActiveContextID(contextID)
	return ctx.context.OnPluginDone()
	}
	return true
	}

我想知道为什么将 OnStreamDone 和 OnHttpStreamDone 从 proxyOnDone 移动到 proxyOnLog 中？最初发生在以下pr

I would like to know the reason for moving OnStreamDone and OnHttpStreamDone from proxyOnDone to proxyOnLog? This change initially occurred in the following PR:

tetratelabs@5653913#diff-39c7215b91b6d02ceae7df97f3ee68081cba42436afcd08c95df524f72707f2a

[007gzs]

@mathetake

[leonm1]

Thank you for raising this issue. I agree that we need a way for plugin authors to execute code in proxyOnDone. Do you have a use-case for separate proxyOnLog and proxyOnDone callbacks?

I do not have any context on why this was changed in the linked commit.

[007gzs]

I report information asynchronously via HTTP calls during requests, which requires returning false in ProxyOnDone of the HttpContext when the asynchronous response hasn't been received yet, and then actively calling Done after the asynchronous report returns. Currently, the OnStreamDone callback cannot achieve this.