Code review

Author: jdnichollsc

CHANGELOG.md

@@ -22,6 +22,18 @@ in case of vulnerabilities.
 
 ## [Unreleased]
 
+## [3.0.0] - 2020-10-30
+### Added
+- Added `hasBackButton` option to sets a back arrow instead of the default X icon to close the custom tab.
+- Added default browser configuration for custom tab if any.
+- Added `browserPackage` option to use a Package name of a browser to be used to handle Custom Tabs.
+- Added `showInRecents` option to determine whether browsed website should be shown as separate entry in Android recents/multitasking view.
+
+### Fixed
+- Android `isAvailable` method checks **Custom Tab** support.
+- Added a null check for `redirectResolve` in `safariViewControllerDidFinish`.
+- Fixed `AppStateActiveOnce` event listener.
+
 ## [2.3.0] - 2020-04-08
 ### Added
 - Added `ephemeralWebSession` option to supports `ephemeralWebBrowserSession` on iOS 13.
@@ -65,7 +77,8 @@ in case of vulnerabilities.
 - Methods to open and close external urls to authenticate the user **(openAuth, closeAuth)** using deep linking.
 - `isAvailable` method to detect if the device supports the plugin.
 
-[Unreleased]: https://github.com/proyecto26/nativescript-inappbrowser/compare/v2.3.0...HEAD
+[Unreleased]: https://github.com/proyecto26/nativescript-inappbrowser/compare/v3.0.0...HEAD
+[3.0.0]: https://github.com/proyecto26/nativescript-inappbrowser/compare/v2.3.0...v3.0.0
 [2.3.0]: https://github.com/proyecto26/nativescript-inappbrowser/compare/v2.2.0...v2.3.0
 [2.2.0]: https://github.com/proyecto26/nativescript-inappbrowser/compare/v2.1.1...v2.2.0
 [2.1.1]: https://github.com/proyecto26/nativescript-inappbrowser/compare/v2.1.0...v2.1.1

README.md

@@ -86,10 +86,9 @@ Property       | Description
 
 ### Demo
 
-```javascript
-import { openUrl } from 'tns-core-modules/utils/utils'
-import { alert } from 'tns-core-modules/ui/dialogs'
-import { InAppBrowser } from 'nativescript-inappbrowser'
+```ts
+import { Utils, Dialogs } from '@nativescript/core';
+import { InAppBrowser } from 'nativescript-inappbrowser';
 
 ...
   openLink = async () => {
@@ -124,24 +123,27 @@ import { InAppBrowser } from 'nativescript-inappbrowser'
           },
           headers: {
             'my-custom-header': 'my custom header value'
-          }
-        })
-        alert({
+          },
+          hasBackButton: true,
+          browserPackage: '',
+          showInRecents: false
+        });
+        Dialogs.alert({
           title: 'Response',
           message: JSON.stringify(result),
           okButtonText: 'Ok'
-        })
+        });
       }
       else {
-        openUrl(url);
+        Utils.openUrl(url);
       }
     }
     catch(error) {
-      alert({
+      Dialogs.alert({
         title: 'Error',
         message: error.message,
         okButtonText: 'Ok'
-      })
+      });
     }
   }
 ...
@@ -181,22 +183,21 @@ define your app scheme and replace `my-scheme` and `my-host` with your info.
 
 - utilities.ts
 ```javascript
-import { android } from "tns-core-modules/application";
 export const getDeepLink = (path = "") => {
   const scheme = 'my-scheme';
-  const prefix = android ? `${scheme}://my-host/` : `${scheme}://`;
+  const prefix = global.isAndroid ? `${scheme}://my-host/` : `${scheme}://`;
   return prefix + path;
 }
 ```
 
 - home-page.ts
-```javascript
-import { openUrl } from 'tns-core-modules/utils/utils';
+```ts
+import { Utils, Dialogs } from '@nativescript/core';
 import { InAppBrowser } from 'nativescript-inappbrowser';
 import { getDeepLink } from './utilities';
 ...
   async onLogin() {
-    const deepLink = getDeepLink("callback")
+    const deepLink = getDeepLink('callback')
     const url = `https://my-auth-login-page.com?redirect_uri=${deepLink}`
     try {
       if (await InAppBrowser.isAvailable()) {
@@ -212,12 +213,12 @@ import { getDeepLink } from './utilities';
             response.type === 'success' &&
             response.url
           ) {
-            openUrl(response.url)
+            Utils.openUrl(response.url)
           }
         })
-      } else openUrl(url)
+      } else Utils.openUrl(url)
     } catch (error) {
-      openUrl(url)
+      Utils.openUrl(url)
     }
   }
 ...

demo/app/home/home-view-model.ts

@@ -55,7 +55,10 @@ export class HelloWorldModel extends Observable {
           },
           headers: {
             'my-custom-header': 'my custom header value'
-          }
+          },
+          hasBackButton: true,
+          browserPackage: '',
+          showInRecents: false
         });
         await sleep(800);
         Dialogs.alert({