Skip to content

Commit 85f3207

Browse files
committed
Code review
1 parent 08a40c1 commit 85f3207

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

demo/app/activity.android.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ export class Activity extends androidx.appcompat.app.AppCompatActivity {
2727
this.getIntent(),
2828
super.onCreate
2929
);
30-
// InAppBrowser initialization (Connect to the Custom Tabs service)
31-
InAppBrowser.onStart();
3230
}
3331

3432
public onNewIntent(intent: android.content.Intent): void {
@@ -50,6 +48,8 @@ export class Activity extends androidx.appcompat.app.AppCompatActivity {
5048

5149
public onStart(): void {
5250
this._callbacks.onStart(this, super.onStart);
51+
// InAppBrowser initialization (Connect to the Custom Tabs service)
52+
InAppBrowser.onStart();
5353
}
5454

5555
public onStop(): void {

demo/app/home/home-view-model.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ export class HelloWorldModel extends Observable {
1212
// Initialize default values.
1313
this._url = "https://nativescript.org";
1414
if (InAppBrowser.warmup()) {
15-
console.log("Warmup successful");
15+
console.log("Warmup successful!");
1616
InAppBrowser.mayLaunchUrl(this._url, [
1717
"https://twitter.com/NativeScript",
1818
"https://github.com/NativeScript/NativeScript",
1919
"https://openjsf.org"
2020
]);
2121
} else {
22-
console.log("Warmup failed");
22+
console.log("Warmup failed :(");
2323
}
2424
}
2525

0 commit comments

Comments
 (0)