Skip to content

Commit ac75852

Browse files
authored
dont throw on activity will crash
In case we end up here and the promise already resolved dont throw or the app will crash with an error like this: ``` Activity {com.elichens.outdoorapp/com.proyecto26.inappbrowser.ChromeTabsManagerActivity} did not call through to super.onDestroy() ``` I am not exactly sure when this could happen but i got that error on sentry and for sure the error comes from here.
1 parent 0450e8e commit ac75852

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/InAppBrowser.android.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ function setup() {
257257
BROWSER_ACTIVITY_EVENTS.off(DISMISSED_EVENT);
258258

259259
if (!InAppBrowserModule.redirectResolve) {
260-
throw new AssertionError();
260+
return;
261261
}
262262
const browserEvent = <ChromeTabsEvent>event.object;
263263
InAppBrowserModule.redirectResolve({

0 commit comments

Comments
 (0)