Skip to content

Commit 79bb1e8

Browse files
authored
Merge pull request #45 from rbscott/fix-double-open
Clear mOpenBrowserPromise after sending a cancel.
2 parents cf661fb + d9cc2a3 commit 79bb1e8

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,9 +234,9 @@ You can than restore the old bar style after the browser has been dismissed like
234234
* **React Native Safari View:** [A React Native wrapper for Safari View Controller](https://github.com/naoufal/react-native-safari-view)
235235

236236
## Collaborators 🥇
237-
[<img alt="jdnichollsc" src="https://avatars3.githubusercontent.com/u/2154886?v=3&s=117" width="117">](https://github.com/jdnichollsc) | [<img alt="EQuimper" src="https://avatars3.githubusercontent.com/u/15819498?v=4&s=117" width="117">](https://github.com/EQuimper) | [<img alt="bonesyblue" src="https://avatars3.githubusercontent.com/u/7486722?s=460&v=4&s=117" width="117">](https://github.com/bonesyblue) | [<img alt="mlazari" src="https://avatars3.githubusercontent.com/u/4928274?v=4&s=117" width="117">](https://github.com/mlazari) | [<img alt="maestor" src="https://avatars3.githubusercontent.com/u/3604902?v=4&s=117" width="117">](https://github.com/maestor) | [<img alt="plamworapot" src="https://avatars3.githubusercontent.com/u/4770354?v=4&s=117" width="117">](https://github.com/plamworapot) | [<img alt="adammcarth" src="https://avatars3.githubusercontent.com/u/3016455?v=4&s=117" width="117">](https://github.com/adammcarth) | [<img alt="SnaiNeR" src="https://avatars0.githubusercontent.com/u/39980963?v=4&s=117" width="117">](https://github.com/SnaiNeR)
238-
:---: | :---: |:---: | :---: | :---: | :---: | :---: | :---: |
239-
[Juan Nicholls](mailto:[email protected]) | [Emanuel Quimper](mailto:[email protected]) | [Jonathan Bones](mailto:[email protected]) | [Mihai Lazari](https://github.com/mlazari) | [Kalle Haavisto](mailto:[email protected]) | [Worapot Pengsuk](https://github.com/plamworapot) | [Adam McArthur](mailto:[email protected]) | [Artem Emelyanov](mailto:[email protected])
237+
[<img alt="jdnichollsc" src="https://avatars3.githubusercontent.com/u/2154886?v=3&s=117" width="117">](https://github.com/jdnichollsc) | [<img alt="EQuimper" src="https://avatars3.githubusercontent.com/u/15819498?v=4&s=117" width="117">](https://github.com/EQuimper) | [<img alt="bonesyblue" src="https://avatars3.githubusercontent.com/u/7486722?s=460&v=4&s=117" width="117">](https://github.com/bonesyblue) | [<img alt="mlazari" src="https://avatars3.githubusercontent.com/u/4928274?v=4&s=117" width="117">](https://github.com/mlazari) | [<img alt="maestor" src="https://avatars3.githubusercontent.com/u/3604902?v=4&s=117" width="117">](https://github.com/maestor) | [<img alt="plamworapot" src="https://avatars3.githubusercontent.com/u/4770354?v=4&s=117" width="117">](https://github.com/plamworapot) | [<img alt="adammcarth" src="https://avatars3.githubusercontent.com/u/3016455?v=4&s=117" width="117">](https://github.com/adammcarth) | [<img alt="SnaiNeR" src="https://avatars0.githubusercontent.com/u/39980963?v=4&s=117" width="117">](https://github.com/SnaiNeR) | [<img alt="rbscott" src="https://avatars2.githubusercontent.com/u/882258?v=4&s=117" width="117">](https://github.com/rbscott)
238+
:---: | :---: |:---: | :---: | :---: | :---: | :---: | :---: | :---: |
239+
[Juan Nicholls](mailto:[email protected]) | [Emanuel Quimper](mailto:[email protected]) | [Jonathan Bones](mailto:[email protected]) | [Mihai Lazari](https://github.com/mlazari) | [Kalle Haavisto](mailto:[email protected]) | [Worapot Pengsuk](https://github.com/plamworapot) | [Adam McArthur](mailto:[email protected]) | [Artem Emelyanov](mailto:[email protected])| [Robert Scott](https://github.com/rbscott)
240240

241241
## Supporting 🍻
242242
I believe in Unicorns 🦄

android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ public void open(Context context, final ReadableMap options, final Promise promi
5151
WritableMap result = Arguments.createMap();
5252
result.putString("type", "cancel");
5353
mOpenBrowserPromise.resolve(result);
54+
mOpenBrowserPromise = null;
5455
return;
5556
}
5657
mOpenBrowserPromise = promise;

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-inappbrowser-reborn",
3-
"version": "1.3.12",
3+
"version": "1.3.13",
44
"description": "InAppBrowser for React Native",
55
"main": "index.js",
66
"readmeFilename": "README.md",

0 commit comments

Comments
 (0)