Code review

Author: jdnichollsc

android/src/main/java/com/proyecto26/inappbrowser/ChromeTabsManagerActivity.java

@@ -20,6 +20,7 @@ public class ChromeTabsManagerActivity extends Activity {
 
   private boolean mOpened = false;
   private String resultType = null;
+  private boolean isError = false;
 
   public static Intent createStartIntent(Context context, Intent authIntent) {
     Intent intent = createBaseIntent(context);
@@ -56,7 +57,8 @@ protected void onCreate(Bundle savedInstanceState) {
         finish();
       }
     } catch (Exception e) {
-      EventBus.getDefault().post(new ChromeTabsDismissedEvent("Unable to open url.", "cancel", true));
+      isError = true;
+      EventBus.getDefault().post(new ChromeTabsDismissedEvent("Unable to open url.", resultType, isError));
       finish();
       e.printStackTrace();
     }
@@ -82,10 +84,10 @@ protected void onDestroy() {
     if (resultType != null) {
       switch (resultType) {
         case "cancel":
-          EventBus.getDefault().post(new ChromeTabsDismissedEvent("chrome tabs activity closed", resultType, false));
+          EventBus.getDefault().post(new ChromeTabsDismissedEvent("chrome tabs activity closed", resultType, isError));
           break;
         default:
-          EventBus.getDefault().post(new ChromeTabsDismissedEvent("chrome tabs activity destroyed", DEFAULT_RESULT_TYPE, false));
+          EventBus.getDefault().post(new ChromeTabsDismissedEvent("chrome tabs activity destroyed", DEFAULT_RESULT_TYPE, isError));
           break;
       }
       resultType = null;

android/src/main/java/com/proyecto26/inappbrowser/RNInAppBrowser.java

@@ -187,6 +187,8 @@ public void open(Context context, final ReadableMap options, final Promise promi
     } catch (Exception e) {
       e.printStackTrace();
     }
+
+    registerEventBus();
 
     intent.setData(Uri.parse(url));
     if (options.hasKey(KEY_SHOW_PAGE_TITLE)) {
@@ -196,8 +198,6 @@ public void open(Context context, final ReadableMap options, final Promise promi
       intent.putExtra(CustomTabsIntent.EXTRA_TITLE_VISIBILITY_STATE, CustomTabsIntent.NO_TITLE);
     }
 
-    registerEventBus();
-
     currentActivity.startActivity(
         ChromeTabsManagerActivity.createStartIntent(currentActivity, intent),
         customTabsIntent.startAnimationBundle);
@@ -243,6 +243,7 @@ public void onEvent(ChromeTabsDismissedEvent event) {
     } else {
       WritableMap result = Arguments.createMap();
       result.putString("type", event.resultType);
+      result.putString("message", event.message);
       mOpenBrowserPromise.resolve(result);
     }
     mOpenBrowserPromise = null;

example/App.js

@@ -96,7 +96,8 @@ export default class App extends Component<ComponentState> {
         Linking.openURL(url);
       }
     } catch (error) {
-      Alert.alert(error.message);
+      console.error(error);
+      Alert.alert(error.message || error);
     } finally {
       // Restore the previous StatusBar of the App
       StatusBar.setBarStyle(statusBarStyle);