chore: Improved linting

Author: Prozilla

demo/package.json

@@ -56,7 +56,7 @@
 		"eslint-plugin-react-refresh": "^0.4.7",
 		"gh-pages": "^6.1.1",
 		"stylelint": "^16.6.1",
-		"typescript": "^5.4.5",
+		"typescript": "^5.5.4",
 		"typescript-eslint": "^7.13.1",
 		"vite-node": "^2.1.2",
 		"vite-plugin-checker": "^0.7.1"

demo/tsconfig.json

@@ -11,7 +11,7 @@
 		"src",
 		"vite.config.ts",
 		"scripts",
-		"../packages/core/src/**/*",
+		"../packages/core/src/**/*", "../types/eslint.d.ts",
 	],
 	"exclude": ["node_modules"]
 }

demo/vite.config.ts

@@ -28,7 +28,7 @@ function generateAliases() {
 		{ name: "prozilla-os", path: resolve(__dirname, "../packages/prozilla-os/" + entryFile) },
 		{ name: "@prozilla-os/core", path: resolve(__dirname, "../packages/core/" + entryFile) },
 		{ name: "@prozilla-os/shared", path: resolve(__dirname, "../packages/shared/" + entryFile) },
-		{ name: "@prozilla-os/skins", path: resolve(__dirname, "../packages/skins/" + entryFile) }
+		{ name: "@prozilla-os/skins", path: resolve(__dirname, "../packages/skins/" + entryFile) },
 	];
 
 	const localApps = [
@@ -66,7 +66,11 @@ export default defineConfig(({ command }) => {
 			react(),
 			checker({
 				typescript: true,
-			})
+				eslint: {
+					lintCommand: "eslint -c ../eslint.config.js ../**/src/**/*",
+					useFlatConfig: true,
+				},
+			}),
 		],
 		build: {
 			outDir: BUILD_DIR,
@@ -77,14 +81,14 @@ export default defineConfig(({ command }) => {
 						appsConfig,
 						siteName: NAME,
 						siteTagLine: TAG_LINE,
-						domain: DOMAIN
-					})
+						domain: DOMAIN,
+					}),
 				],
 				output: {
 					assetFileNames: "assets/[name][extname]",
 					chunkFileNames: "chunks/[name]-[hash].js",
 					entryFileNames: "[name].js",
-				}
+				},
 			},
 		},
 		resolve: {
@@ -95,6 +99,6 @@ export default defineConfig(({ command }) => {
 		},
 		optimizeDeps: {
 			exclude: devMode ? Object.keys(aliases) : [],
-		}
+		},
 	} as UserConfig;
 });

eslint.config.js

@@ -21,14 +21,12 @@ export default tseslint.config(
 			"**/dist/**/*"
 		],
 		plugins: {
-			// @ts-ignore
-			react,
+			"react": /** @type {import("eslint").ESLint.Plugin} */ (react),
 			"react-refresh": reactRefresh,
 		},
 		rules: {
 			"quotes": ["error", "double"],
 			"no-unused-vars": "off",
-			"@typescript-eslint/ban-types": "off",
 			"indent": [
 				"error",
 				"tab",
@@ -46,38 +44,112 @@ export default tseslint.config(
 			"default-case": "off",
 			"arrow-parens": "error",
 			"space-infix-ops": "warn",
-			"react/no-multi-comp": [
-				"error",
+    		"comma-spacing": "warn",
+			"comma-dangle": [
+				"warn",
 				{
-					"ignoreStateless": true
+					"arrays": "always-multiline",
+					"objects": "always-multiline",
+					"imports": "always-multiline",
+					"exports": "always-multiline",
+					"functions": "never"
 				}
 			],
-    		"comma-spacing": "warn",
-			"@typescript-eslint/no-unused-vars": [
-				"warn",
+			"keyword-spacing": "error",
+			"react/no-multi-comp": [
+				"error",
 				{
-					"argsIgnorePattern": "^_"
+					"ignoreStateless": true
 				}
 			],
+			"react/no-invalid-html-attribute": "error",
+			"react/boolean-prop-naming": "warn",
+			"react/jsx-handler-names": "warn",
 			"react-refresh/only-export-components": [
 				"warn",
 				{ "allowConstantExport": true }
 			],
-			"@typescript-eslint/await-thenable": "off",
-			"react/boolean-prop-naming": "warn",
-			"react/jsx-handler-names": "warn",
-			"comma-dangle": [
+			"@typescript-eslint/ban-types": "off",
+			"@typescript-eslint/no-unused-vars": [
 				"warn",
 				{
-					"arrays": "always-multiline",
-					"objects": "always-multiline",
-					"imports": "always-multiline",
-					"exports": "always-multiline",
-					"functions": "never"
+					"args": "all",
+					"argsIgnorePattern": "^_",
+					"caughtErrors": "all",
+					"caughtErrorsIgnorePattern": "^_",
+					"destructuredArrayIgnorePattern": "^_",
+					"varsIgnorePattern": "^_",
+					"ignoreRestSiblings": true
 				}
 			],
-			"keyword-spacing": "error",
-			"react/no-invalid-html-attribute": "error",
+			"@typescript-eslint/naming-convention": [
+				"error",
+				{
+					selector: "default",
+					format: ["camelCase"],
+					leadingUnderscore: "allow",
+					trailingUnderscore: "allow",
+				},
+				{
+					selector: "import",
+					format: ["camelCase", "PascalCase"],
+				},
+				{
+					// React components and Variables
+					selector: "variable",
+					format: ["camelCase", "UPPER_CASE", "PascalCase"],
+					leadingUnderscore: "allow",
+				},
+				{
+					// Types and enum members
+					selector: ["typeLike", "enumMember"],
+					format: ["PascalCase"],
+				},
+				{
+					// React components, functions and properties
+					selector: [
+						"function",
+						"parameter",
+						"classProperty",
+						"objectLiteralProperty",
+						"typeProperty",
+						"classMethod",
+						"objectLiteralMethod",
+						"typeMethod",
+						"accessor",
+					],
+					format: ["camelCase", "PascalCase"],
+					leadingUnderscore: "allow",
+				},
+				{
+					// Static class fields
+					selector: "classProperty",
+					modifiers: ["static"],
+					format: ["UPPER_CASE"],
+				},
+				{
+					// Ignore destructured variables and parameters
+					selector: ["variable", "parameter"],
+					modifiers: ["destructured"],
+					format: null,
+				},
+				{
+					// Ignore properties that require quotes
+					selector: [
+						"classProperty",
+						"objectLiteralProperty",
+						"typeProperty",
+						"classMethod",
+						"objectLiteralMethod",
+						"typeMethod",
+						"accessor",
+						"enumMember",
+					],
+					modifiers: ["requiresQuotes"],
+					format: null,
+				},
+			],
+			"@typescript-eslint/await-thenable": "off"
 		},
 	}
 );

package.json

@@ -54,7 +54,7 @@
 		"eslint-plugin-react-refresh": "^0.4.7",
 		"rimraf": "^5.0.10",
 		"stylelint": "^16.6.1",
-		"typescript": "^5.4.5",
+		"typescript": "^5.5.4",
 		"typescript-eslint": "^8.8.1",
 		"vite-node": "^2.1.2",
 		"vite-plugin-checker": "^0.7.1"

packages/apps/app-center/package.json

@@ -30,7 +30,7 @@
 		"@types/node": "^20.14.5",
 		"@types/react": "^18.3.3",
 		"@vitejs/plugin-react-swc": "^3.7.0",
-		"typescript": "^5.4.5",
+		"typescript": "^5.5.4",
 		"vite": "^5.4.8",
 		"vite-plugin-dts": "^3.9.1",
 		"vite-plugin-lib-inject-css": "^2.1.1"

packages/apps/app-center/src/components/list/List.tsx

@@ -12,7 +12,7 @@ export function List({ apps, searchQuery, category }: ListProps) {
 	return <div className={styles.List}>
 		{apps.filter(({ name, id, category: appCategory }) => {
 			return (name.toLowerCase().includes(searchQuery) || id.toLowerCase().replaceAll("-", " ").includes(searchQuery))
-				&& (category == "All" || appCategory == category)
+				&& (category == "All" || appCategory == category);
 		}).map(({ name, id, iconUrl }) =>
 			<div key={id} className={styles.App}>
 				<div className={styles.AppIcon}>{iconUrl && <Image src={iconUrl}/>}</div>

packages/apps/browser/package.json

@@ -30,7 +30,7 @@
 		"@types/node": "^20.14.5",
 		"@types/react": "^18.3.3",
 		"@vitejs/plugin-react-swc": "^3.7.0",
-		"typescript": "^5.4.5",
+		"typescript": "^5.5.4",
 		"vite": "^5.4.8",
 		"vite-plugin-dts": "^3.9.1",
 		"vite-plugin-lib-inject-css": "^2.1.1"

packages/apps/browser/src/main.ts

@@ -3,7 +3,7 @@ import { Browser, BrowserProps } from "./components/Browser";
 
 const browser = new App<BrowserProps>("Browser", "browser", Browser, { size: new Vector2(700, 500) })
 	.setIconUrl("https://os.prozilla.dev/assets/apps/icons/browser.svg")
-	.setRole(AppsConfig.APP_ROLES.Browser)
+	.setRole(AppsConfig.APP_ROLES.browser)
 	.setCategory("Utilities & tools");
 
 export { browser };

packages/apps/calculator/package.json

@@ -30,7 +30,7 @@
 		"@types/node": "^20.14.5",
 		"@types/react": "^18.3.3",
 		"@vitejs/plugin-react-swc": "^3.7.0",
-		"typescript": "^5.4.5",
+		"typescript": "^5.5.4",
 		"vite": "^5.4.8",
 		"vite-plugin-dts": "^3.9.1",
 		"vite-plugin-lib-inject-css": "^2.1.1"