Skip to content

Commit 01ce024

Browse files
committed
Don't send logs if there are no metrics
1 parent 7642820 commit 01ce024

File tree

3 files changed

+10
-0
lines changed

3 files changed

+10
-0
lines changed

emf/logger.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,11 @@ func (l *Logger) Log() {
162162
// TODO check if not empty as above?
163163
metrics = append(metrics, v.metricDirective)
164164
}
165+
166+
if len(metrics) == 0 {
167+
return
168+
}
169+
165170
l.values["_aws"] = Metadata{
166171
Timestamp: l.timestamp,
167172
Metrics: metrics,

emf/logger_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,11 @@ func TestEmf(t *testing.T) {
171171
},
172172
expected: "testdata/16.json",
173173
},
174+
{
175+
name: "no metrics set",
176+
given: func(logger *emf.Logger) {},
177+
expected: "testdata/17.txt",
178+
},
174179
}
175180

176181
for _, tc := range tcs {

emf/testdata/17.txt

Whitespace-only changes.

0 commit comments

Comments
 (0)