Skip to content

Commit 7eb22d3

Browse files
committed
check for null; clean up
1 parent 613f715 commit 7eb22d3

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/transform/action/PutTransformAction.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,11 +169,13 @@ public Task createTask(long id, String type, String action, TaskId parentTaskId,
169169
public interface TransformTaskMatcher {
170170
static boolean match(Task task, String expectedTransformId) {
171171
return task instanceof TransformTaskMatcher
172+
&& expectedTransformId != null
172173
&& task.getDescription().equals(TransformField.PERSISTENT_TASK_DESCRIPTION_PREFIX + expectedTransformId);
173174
}
174175

175176
static boolean match(Task task, Collection<String> expectedTransformIds) {
176-
return task instanceof PutTransformAction.TransformTaskMatcher
177+
return task instanceof TransformTaskMatcher
178+
&& expectedTransformIds != null
177179
&& expectedTransformIds.stream()
178180
.anyMatch(transformId -> task.getDescription().equals(TransformField.PERSISTENT_TASK_DESCRIPTION_PREFIX + transformId));
179181
}

x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/transform/action/StopTransformActionRequestTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,7 @@ public void testMatch() {
7373
TransformField.PERSISTENT_TASK_DESCRIPTION_PREFIX + transformId,
7474
TaskId.EMPTY_TASK_ID,
7575
Collections.emptyMap()
76-
) {
77-
};
76+
);
7877

7978
Request request = new Request("unrelated", false, false, null, false, false);
8079
request.setExpandedIds(Set.of("foo", "bar"));

0 commit comments

Comments
 (0)