Fix warnings, and make sure New16 is aligned

Author: rickgaiser

include/ps2s/core.h

@@ -57,10 +57,14 @@ inline ptrType MakePtrUncachedAccl(ptrType ptr)
 
 // used to override new() to allocate on qword boundaries (only for linux)
 
-// PLIN -- need to override delete as well...
 inline void* New16(size_t size)
 {
-    return ::operator new(size);
+    return ::operator new(size, std::align_val_t(16));
+}
+
+inline void Delete16(void* p)
+{
+    ::operator delete(p);
 }
 
 // cop0 counter

include/ps2s/displayenv.h

@@ -126,10 +126,8 @@ class CDisplayEnv {
 
     void SendSettings(void);
 
-    inline void* operator new(size_t size)
-    {
-        return Core::New16(size);
-    }
+    inline void* operator new(size_t size) { return Core::New16(size); }
+    inline void operator delete(void* p) { Core::Delete16(p); }
 
 protected:
 private:

include/ps2s/drawenv.h

@@ -189,10 +189,8 @@ class CDrawEnv {
     // accessors
     tU32 GetFrameBufferAddr(void) { return gsrFrame.fb_addr * 2048; }
 
-    inline void* operator new(size_t size)
-    {
-        return Core::New16(size);
-    }
+    inline void* operator new(size_t size) { return Core::New16(size); }
+    inline void operator delete(void* p) { Core::Delete16(p); }
 
 protected:
     tSourceChainTag SettingsDmaTag;

include/ps2s/imagepackets.h

@@ -70,10 +70,8 @@ class CImageUploadPkt : protected CVifSCDmaPacket {
     void Send(CSCDmaPacket& packet);
     void Send(CVifSCDmaPacket& packet);
 
-    inline void* operator new(size_t size)
-    {
-        return Core::New16(size);
-    }
+    inline void* operator new(size_t size) { return Core::New16(size); }
+    inline void operator delete(void* p) { Core::Delete16(p); }
 
 protected:
 private:
@@ -135,10 +133,8 @@ class CClutUploadPkt : protected CImageUploadPkt {
     inline void Send(CSCDmaPacket& packet) { CImageUploadPkt::Send(packet); }
     inline void Send(CVifSCDmaPacket& packet) { CImageUploadPkt::Send(packet); }
 
-    inline void* operator new(size_t size)
-    {
-        return Core::New16(size);
-    }
+    inline void* operator new(size_t size) { return Core::New16(size); }
+    inline void operator delete(void* p) { Core::Delete16(p); }
 };
 
 #endif // ps2s_imagepackets_h

include/ps2s/sprite.h

@@ -82,10 +82,8 @@ class CSprite {
 
     CDmaPacket& GetPacket(void) { return GifPacket; }
 
-    inline void* operator new(size_t size)
-    {
-        return Core::New16(size);
-    }
+    inline void* operator new(size_t size) { return Core::New16(size); }
+    inline void operator delete(void* p) { Core::Delete16(p); }
 
 protected:
 private:

include/ps2s/texture.h

@@ -120,10 +120,8 @@ class CTexEnv {
     CTexEnv(const CTexEnv& rhs);
     CTexEnv& operator=(const CTexEnv& rhs);
 
-    inline void* operator new(size_t size)
-    {
-        return Core::New16(size);
-    }
+    inline void* operator new(size_t size) { return Core::New16(size); }
+    inline void operator delete(void* p) { Core::Delete16(p); }
 
 protected:
     // gs packet to setup texture environment

src/gsmem.cpp

@@ -108,15 +108,13 @@ void CMemSlotList::PrintSlots()
 
 void CMemSlotList::RemoveSlot(CMemSlot* slot)
 {
-    bool found        = false;
     tSlotIter curSlot = Slots.begin();
     for (; curSlot != Slots.end(); curSlot++)
         if (*curSlot == slot) {
-            found = true;
             break;
         }
 
-    mErrorIf(!found, "This list does not contain the specified slot!");
+    mErrorIf((*curSlot != slot), "This list does not contain the specified slot!");
 
     Slots.erase(curSlot);
 }