Driver Corrections

Author: pschatzmann

src/Driver.h

@@ -193,7 +193,7 @@ class AudioDriver {
     GpioPin  pin = pins().getPinID(PinFunction::PA);
     if (pin == -1)
       return false;
-    //AD_LOGI("setPAPower pin %d -> %d", pin, enable);
+    AD_LOGI("setPAPower pin %d -> %d", pin, enable);
     digitalWrite(pin, enable ? HIGH : LOW);
     return true;
   }
@@ -286,13 +286,13 @@ class AudioDriverAC101Class : public AudioDriver {
 };
 
 /**
- * @brief Driver API for the CS43l22 codec chip
+ * @brief Driver API for the CS43l22 codec chip on 0x94 (0x4A<<1)
  * @author Phil Schatzmann
  * @copyright GPLv3
  */
 class AudioDriverCS43l22Class : public AudioDriver {
 public:
-  AudioDriverCS43l22Class(uint16_t deviceAddr = 0x94) {
+  AudioDriverCS43l22Class(uint16_t deviceAddr = 0x94 ) {
     this->deviceAddr = deviceAddr;
   }
 
@@ -304,12 +304,18 @@ class AudioDriverCS43l22Class : public AudioDriver {
     codec_cfg = codecCfg;
     // manage reset pin -> acive high
     setPAPower(true);
-    delay(10);
+  // Setup enable pin for codec
+    delay(100);
     int vol = map(volume, 0, 100, DEFAULT_VOLMIN, DEFAULT_VOLMAX);
     uint32_t freq = getFrequency(codec_cfg.i2s.rate);
     uint16_t outputDevice = getOutput(codec_cfg.output_device);
     AD_LOGD("cs43l22_Init");
-    return cs43l22_Init(deviceAddr, outputDevice, vol, freq, getI2C()) == 0;
+    bool result = cs43l22_Init(deviceAddr, outputDevice, vol, freq, getI2C()) == 0;
+    if (!result){
+      AD_LOGE("error: cs43l22_Init");
+    }
+    cs43l22_Play(deviceAddr, nullptr, 0);
+    return result;
   }
 
   bool setMute(bool mute) {

src/Driver/cs43l22/cs43l22.c

@@ -477,8 +477,8 @@ static uint8_t CODEC_IO_Write(uint8_t Addr, uint8_t Reg, uint8_t Value)
 
 void      AUDIO_IO_Init(void) {}
 void      AUDIO_IO_DeInit(void) {}
-void      AUDIO_IO_Write(uint8_t addr, uint16_t reg, uint8_t value) {
-  i2c_bus_write_bytes(i2c_handle, addr, (uint8_t *)&reg, sizeof(uint16_t), &value, 1);
+void      AUDIO_IO_Write(uint8_t addr, uint8_t reg, uint8_t value) {
+  i2c_bus_write_bytes(i2c_handle, addr, &reg, 1, &value, 1);
 }
 
 

src/Driver/cs43l22/cs43l22.h

@@ -196,8 +196,8 @@ uint32_t cs43l22_Reset(uint16_t DeviceAddr);
 /* AUDIO IO functions */
 void      AUDIO_IO_Init(void);
 void      AUDIO_IO_DeInit(void);
-void      AUDIO_IO_Write(uint8_t Addr, uint16_t Reg, uint8_t Value);
-uint8_t   AUDIO_IO_Read(uint8_t Addr, uint16_t Reg);
+void      AUDIO_IO_Write(uint8_t Addr, uint8_t Reg, uint8_t Value);
+uint8_t   AUDIO_IO_Read(uint8_t Addr, uint8_t Reg);
 
 /* Audio driver structure */
 //extern AUDIO_DrvTypeDef   cs43l22_drv;

src/Driver/es7210/es7210.c

@@ -507,6 +507,6 @@ void es7210_read_all(void)
 {
     for (int i = 0; i <= 0x4E; i++) {
         uint8_t reg = es7210_read_reg(i);
-        AD_LOGI("REG:%02x, %02x\n", reg, i);
+        AD_LOGI("REG:%02x, %02x", reg, i);
     }
 }

src/Driver/es7243/es7243.c

@@ -120,7 +120,7 @@ error_t es7243_adc_config_i2s(codec_mode_t mode, I2SDefinition *iface)
 
 error_t es7243_adc_set_voice_mute(bool mute)
 {
-    AD_LOGI( "Enter into es7243_mute(), mute = %d\n", mute);
+    AD_LOGI( "Enter into es7243_mute(), mute = %d", mute);
     if (mute) {
         es7243_write_reg(0x05, 0x1B);
     } else {

src/Driver/es8311/es8311.c

@@ -233,7 +233,7 @@ static int get_coeff(uint32_t mclk, uint32_t rate)
 static void es8311_mute(int mute)
 {
     uint8_t regv;
-    AD_LOGI( "Enter into es8311_mute(), mute = %d\n", mute);
+    AD_LOGI( "Enter into es8311_mute(), mute = %d", mute);
     regv = es8311_read_reg(ES8311_DAC_REG31) & 0x9f;
     if (mute) {
         es8311_write_reg(ES8311_SYSTEM_REG12, 0x02);
@@ -700,6 +700,6 @@ void es8311_read_all()
 {
     for (int i = 0; i < 0x4A; i++) {
         uint8_t reg = es8311_read_reg(i);
-        AD_LOGI("REG:%02x, %02x\n", reg, i);
+        AD_LOGI("REG:%02x, %02x", reg, i);
     }
 }

src/Driver/es8388/es8388.c

@@ -51,7 +51,7 @@ void es8388_read_all()
     for (int i = 0; i < 50; i++) {
         uint8_t reg = 0;
         es_read_reg(i, &reg);
-        AD_LOGI("%x: %x\n", i, reg);
+        AD_LOGI("%x: %x", i, reg);
     }
 }
 
@@ -76,7 +76,7 @@ static int es8388_set_adc_dac_volume(int mode, int volume, int dot)
     AD_LOGD("es8388_set_adc_dac_volume: %d.%d", volume,dot);
     int res = 0;
     if ( volume < -96 || volume > 0 ) {
-        AD_LOGW("Warning: volume < -96! or > 0!\n");
+        AD_LOGW("Warning: volume < -96! or > 0!");
         if (volume < -96)
             volume = -96;
         else

src/Driver/tas5805m/tas5805m.c

@@ -90,7 +90,7 @@ static error_t tas5805m_transmit_registers(const tas5805m_cfg_reg_t *conf_buf, i
                 break;
             case CFG_END_1:
                 if (CFG_END_2 == conf_buf[i + 1].offset && CFG_END_3 == conf_buf[i + 2].offset) {
-                    AD_LOGI( "End of tms5805m reg: %d\n", i);
+                    AD_LOGI( "End of tms5805m reg: %d", i);
                 }
                 break;
             default:

src/Driver/wm8994/wm8994.c

@@ -525,7 +525,7 @@ uint32_t wm8994_ReadID(uint16_t DeviceAddr)
   /* Initialize the Control interface of the Audio Codec */
   AUDIO_IO_Init();
 
-  return ((uint32_t)AUDIO_IO_Read(DeviceAddr, WM8994_CHIPID_ADDR));
+  return ((uint32_t)AUDIO_IO_Read16(DeviceAddr, WM8994_CHIPID_ADDR));
 }
 
 /**

src/Driver/wm8994/wm8994.h

@@ -154,7 +154,7 @@ uint32_t wm8994_Reset(uint16_t DeviceAddr);
 void    AUDIO_IO_Init(void);
 void    AUDIO_IO_DeInit(void);
 void    AUDIO_IO_Write16(uint8_t Addr, uint16_t Reg, uint16_t Value);
-uint8_t AUDIO_IO_Read(uint8_t Addr, uint16_t Reg);
+uint8_t AUDIO_IO_Read16(uint8_t Addr, uint16_t Reg);
 void    AUDIO_IO_Delay(uint32_t Delay);
 
 /* Audio driver structure */