Change AudioSource: begin from void to bool

Author: pschatzmann

src/AudioTools/Disk/AudioSource.h

@@ -16,7 +16,7 @@ namespace audio_tools {
 class AudioSource {
  public:
   /// Reset actual stream and move to root
-  virtual void begin() = 0;
+  virtual bool begin() = 0;
 
   /// Returns next audio stream
   virtual Stream* nextStream(int offset) = 0;
@@ -90,9 +90,10 @@ class AudioSourceCallback : public AudioSource {
   }
 
   /// Reset actual stream and move to root
-  virtual void begin() override {
+  virtual bool begin() override {
     TRACED();
     if (onStartCallback != nullptr) onStartCallback();
+    return true;
   };
 
   /// Returns next (with positive index) or previous stream (with negative
@@ -259,10 +260,11 @@ class AudioSourceVector : public AudioSource, public PathNamesRegistry {
       : nameToStreamCallback(callback) {}
 
   /// Reset actual stream and move to root
-  virtual void begin() override {
+  bool begin() override {
     TRACED();
     current_index = 0;
     current_stream = nullptr;
+    return true;
   }
 
   /// Returns next audio stream
@@ -548,10 +550,11 @@ class AudioSourceArray : public AudioSource {
         nameToStreamCallback(callback) {}
 
   /// Reset actual stream and move to root
-  virtual void begin() override {
+  virtual bool begin() override {
     TRACED();
     current_index = 0;
     current_stream = nullptr;
+    return true;
   }
 
   /// Returns next audio stream

src/AudioTools/Disk/AudioSourceFTP.h

@@ -30,11 +30,11 @@ class AudioSourceFTP : public AudioSource {
   }
 
   /// Resets the actual data
-  void begin()override {
+  bool begin()override {
     TRACED();
     idx = 0;
     files.clear();
-    addDirectory(p_path);
+    return addDirectory(p_path);
   }
 
   /// Resets the actual data

src/AudioTools/Disk/AudioSourceIdxSD.h

@@ -51,7 +51,7 @@ class AudioSourceIdxSD : public AudioSource {
   }
 #endif
 
-  virtual void begin() override {
+  virtual bool begin() override {
     TRACED();
     if (!is_sd_setup) {
       while (!start_sd()) {
@@ -62,6 +62,7 @@ class AudioSourceIdxSD : public AudioSource {
     }
     idx.begin(start_path, extension, file_name_pattern, setup_index);
     idx_pos = 0;
+    return is_sd_setup;
   }
 
   void end() {

src/AudioTools/Disk/AudioSourceIdxSDFAT.h

@@ -69,17 +69,18 @@ class AudioSourceIdxSDFAT : public AudioSource {
 
   virtual ~AudioSourceIdxSDFAT() { end(); }
 
-  virtual void begin() override {
+  virtual bool begin() override {
     TRACED();
     if (!is_sd_setup) {
       if (!sd.begin(*p_cfg)) {
         LOGE("sd.begin failed");
-        return;
+        return false;
       }
       is_sd_setup = true;
     }
     idx.begin(start_path, exension, file_name_pattern, setup_index);
     idx_pos = 0;
+    return is_sd_setup;
   }
 
   void end() {

src/AudioTools/Disk/AudioSourceIdxSDMMC.h

@@ -39,17 +39,18 @@ class AudioSourceIdxSDMMC : public AudioSource {
     setup_index = setupIndex;
   }
 
-  virtual void begin() override {
+  virtual __GCC_ATOMIC_BOOL_LOCK_FREE begin() override {
     TRACED();
     if (!is_sd_setup) {
       if (!SD_MMC.begin("/sdcard", true)) {
         LOGE("SD_MMC.begin failed");
-        return;
+        return false;
       }
       is_sd_setup = true;
     }
     idx.begin(start_path, exension, file_name_pattern, setup_index);
     idx_pos = 0;
+    return is_sd_setup;
   }
 
   void end() {

src/AudioTools/Disk/AudioSourceLittleFS.h

@@ -21,7 +21,7 @@ class AudioSourceLittleFS : public AudioSource {
     exension = ext;
   }
 
-  virtual void begin() override {
+  virtual bool begin() override {
     TRACED();
     if (!is_sd_setup) {
       while (!LittleFS.begin()) {
@@ -32,6 +32,7 @@ class AudioSourceLittleFS : public AudioSource {
     }
     idx.begin(start_path, exension, file_name_pattern);
     idx_pos = 0;
+    return is_sd_setup;
   }
 
   void end() {

src/AudioTools/Disk/AudioSourceSD.h

@@ -53,7 +53,7 @@ class AudioSourceSD : public AudioSource {
 
 #endif
 
-  virtual void begin() override {
+  virtual bool begin() override {
     TRACED();
     if (!is_sd_setup) {
       while (!start_sd()) {
@@ -64,6 +64,7 @@ class AudioSourceSD : public AudioSource {
     }
     idx.begin(start_path, extension, file_name_pattern);
     idx_pos = 0;
+    return is_sd_setup;
   }
 
   void end() {

src/AudioTools/Disk/AudioSourceSDFAT.h

@@ -72,17 +72,18 @@ class AudioSourceSDFAT : public AudioSource {
     if (owns_cfg) delete (p_cfg);
   }
 
-  virtual void begin() override {
+  virtual bool begin() override {
     TRACED();
     if (!is_sd_setup) {
       if (!sd.begin(*p_cfg)) {
         LOGE("sd.begin failed");
-        return;
+        return false;
       }
       is_sd_setup = true;
     }
     idx.begin(start_path, exension, file_name_pattern);
     idx_pos = 0;
+    return is_sd_setup;
   }
 
   void end() {

src/AudioTools/Disk/AudioSourceSDMMC.h

@@ -38,7 +38,7 @@ class AudioSourceSDMMC : public AudioSource {
     setup_index = setupIndex;
   }
 
-  virtual void begin() override {
+  virtual bool begin() override {
     TRACED();
     if (!is_sd_setup) {
       if (!SD_MMC.begin("/sdcard", true)) {
@@ -49,6 +49,7 @@ class AudioSourceSDMMC : public AudioSource {
     }
     idx.begin(start_path, exension, file_name_pattern);
     idx_pos = 0;
+    return is_sd_setup;
   }
 
   void end() {

src/AudioTools/Disk/AudioSourceSPIFFS.h

@@ -21,7 +21,7 @@ class AudioSourceSPIFFS : public AudioSource {
     exension = ext;
   }
 
-  virtual void begin() override {
+  virtual bool begin() override {
     TRACED();
     if (!is_sd_setup) {
       while (!SPIFFS.begin()) {
@@ -32,6 +32,7 @@ class AudioSourceSPIFFS : public AudioSource {
     }
     idx.begin(start_path, exension, file_name_pattern);
     idx_pos = 0;
+    return is_sd_setup;
   }
 
   void end() {