Fix race condition in esp now communication (#1673)

dosas · dosas · web-flow · commit 284d5256935c · 2024-08-22T21:14:46.000+02:00
when calling mac address to fast after setting it

happened on ESP32-WROOM-32E with IDF version &gt; 5

Co-authored-by: dosas &lt;dosas@github.com&gt;
diff --git a/src/Communication/ESPNowStream.h b/src/Communication/ESPNowStream.h
@@ -112,6 +112,7 @@ class ESPNowStream : public BaseStream {
         LOGE("Could not set mac address");
         return false;
       }
+      delay(500);  // On some boards calling macAddress to early leads to a race condition.
       // checking if address has been updated
       const char *addr = macAddress();
       if (strcmp(addr, cfg.mac_address) != 0) {

Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,7 @@ class ESPNowStream : public BaseStream {`
`112`	`112`	`LOGE("Could not set mac address");`
`113`	`113`	`return false;`
`114`	`114`	`}`
	`115`	`+ delay(500); // On some boards calling macAddress to early leads to a race condition.`
`115`	`116`	`// checking if address has been updated`
`116`	`117`	`const char *addr = macAddress();`
`117`	`118`	`if (strcmp(addr, cfg.mac_address) != 0) {`