Skip to content

Commit 36a64fe

Browse files
committed
Comment for AnalogDriverESP32V2
1 parent 1fd8a48 commit 36a64fe

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

src/AudioTools/CoreAudio/AudioAnalog/AnalogDriverESP32V2.h

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,20 @@ namespace audio_tools {
2020

2121
/**
2222
* @brief AnalogAudioStream: A very fast DAC using DMA using the new
23-
* dac_continuous API
23+
* dac_continuous API. This implementation assumes that the issue with
24+
* the different number of samples per channel has been resolved!
25+
* https://github.com/espressif/esp-idf/issues/12337
2426
* @ingroup platform
2527
* @author Phil Schatzmann
2628
* @copyright GPLv3
2729
*/
28-
class AnalogDriverESP32V1 : public AnalogDriverBase {
30+
class AnalogDriverESP32V2 : public AnalogDriverBase {
2931
public:
3032
/// Default constructor
31-
AnalogDriverESP32V1() = default;
33+
AnalogDriverESP32V2() = default;
3234

3335
/// Destructor
34-
virtual ~AnalogDriverESP32V1() {
36+
virtual ~AnalogDriverESP32V2() {
3537
end();
3638
}
3739

@@ -123,7 +125,7 @@ class AnalogDriverESP32V1 : public AnalogDriverBase {
123125
// ----------------------------------------------------------
124126
class IO16Bit : public AudioStream {
125127
public:
126-
IO16Bit(AnalogDriverESP32V1 *driver) { self = driver; }
128+
IO16Bit(AnalogDriverESP32V2 *driver) { self = driver; }
127129

128130
/// Write int16_t data to the Digital to Analog Converter
129131
size_t write(const uint8_t *src, size_t size_bytes) override {
@@ -227,7 +229,7 @@ class AnalogDriverESP32V1 : public AnalogDriverBase {
227229
}
228230

229231
protected:
230-
AnalogDriverESP32V1 *self = nullptr;
232+
AnalogDriverESP32V2 *self = nullptr;
231233
Vector<uint8_t> result_data{0};
232234
Vector<int> sampleIndex{0};
233235

@@ -612,7 +614,7 @@ class AnalogDriverESP32V1 : public AnalogDriverBase {
612614
};
613615

614616
/// @brief AnalogAudioStream
615-
using AnalogDriver = AnalogDriverESP32V1;
617+
using AnalogDriver = AnalogDriverESP32V2;
616618

617619
} // namespace audio_tools
618620

0 commit comments

Comments
 (0)