Compile warnings: Add missing override

Author: pschatzmann

src/AudioTools/AudioCodecs/AudioCodecsBase.h

@@ -22,10 +22,10 @@ class AudioDecoder : public AudioWriter, public AudioInfoSource {
   AudioDecoder(AudioDecoder const &) = delete;
   AudioDecoder &operator=(AudioDecoder const &) = delete;
 
-  virtual AudioInfo audioInfo() { return info; };
+  AudioInfo audioInfo() override { return info; };
 
   /// for most decoders this is not needed
-  virtual void setAudioInfo(AudioInfo from) override {
+  void setAudioInfo(AudioInfo from) override {
     TRACED();
     if (info != from) {
       notifyAudioChange(from);
@@ -97,7 +97,7 @@ class AudioEncoder : public AudioWriter {
   virtual const char *mime() = 0;
   /// Defines the sample rate, number of channels and bits per sample
   void setAudioInfo(AudioInfo from) override { info = from; }
-  AudioInfo audioInfo() { return info; }
+  AudioInfo audioInfo() override { return info; }
 
  protected:
   AudioInfo info;
@@ -230,10 +230,10 @@ class StreamingDecoderAdapter : public StreamingDecoder {
   AudioInfo audioInfo() override { return p_decoder->audioInfo(); }
 
   /// checks if the class is active
-  virtual operator bool() { return *p_decoder; }
+  virtual operator bool() override { return *p_decoder; }
 
   /// Process a single read operation - to be called in the loop
-  virtual bool copy() {
+  virtual bool copy() override {
     int read = readBytes(&buffer[0], buffer.size());
     int written = 0;
     if (read > 0) written = p_decoder->write(&buffer[0], read);

src/AudioTools/AudioCodecs/AudioEncoded.h

@@ -94,7 +94,7 @@ class EncodedAudioOutput : public ModifyingOutput {
     }
   }
 
-  void setOutput(Print &outputStream) { setOutput(&outputStream); }
+  void setOutput(Print &outputStream) override { setOutput(&outputStream); }
 
   /// Defines the output
   void setOutput(Print *outputStream) {
@@ -151,7 +151,7 @@ class EncodedAudioOutput : public ModifyingOutput {
   }
 
   /// Starts the processing - sets the status to active
-  virtual bool begin(AudioInfo newInfo) {
+  virtual bool begin(AudioInfo newInfo) override {
     cfg = newInfo;
     return begin();
   }
@@ -194,7 +194,7 @@ class EncodedAudioOutput : public ModifyingOutput {
   }
 
   /// Returns true if status is active and we still have data to be processed
-  operator bool() { return active; }
+  operator bool() override { return active; }
 
   /// Provides the initialized decoder
   AudioDecoder &decoder() { return *decoder_ptr; }
@@ -286,22 +286,22 @@ class EncodedAudioStream : public ReformatBaseStream {
 
   void setOutput(Print *stream) { setOutput(*stream); }
 
-  void setStream(AudioStream &stream) {
+  void setStream(AudioStream &stream) override {
     ReformatBaseStream::setStream(stream);
     enc_out.setOutput(&stream);
   }
 
-  void setStream(Stream &stream) {
+  void setStream(Stream &stream) override {
     ReformatBaseStream::setStream(stream);
     enc_out.setOutput(&stream);
   }
 
-  void setOutput(AudioOutput &stream) {
+  void setOutput(AudioOutput &stream) override {
     ReformatBaseStream::setOutput(stream);
     enc_out.setOutput(&stream);
   }
 
-  void setOutput(Print &out) {
+  void setOutput(Print &out) override {
     ReformatBaseStream::setOutput(out);
     enc_out.setOutput(&out);
   }
@@ -316,26 +316,26 @@ class EncodedAudioStream : public ReformatBaseStream {
     return begin();
   }
 
-  bool begin() {
+  bool begin() override {
     // is_output_notify = false;
     setupReader();
     ReformatBaseStream::begin();
     return enc_out.begin(audioInfo());
   }
 
-  void end() {
+  void end() override {
     enc_out.end();
     reader.end();
   }
 
-  int availableForWrite() { return enc_out.availableForWrite(); }
+  int availableForWrite() override { return enc_out.availableForWrite(); }
 
-  size_t write(const uint8_t *data, size_t len) {
+  size_t write(const uint8_t *data, size_t len) override {
     // addNotifyOnFirstWrite();
     return enc_out.write(data, len);
   }
 
-  size_t readBytes(uint8_t *data, size_t len) {
+  size_t readBytes(uint8_t *data, size_t len) override {
     return reader.readBytes(data, len);
   }
 
@@ -344,7 +344,7 @@ class EncodedAudioStream : public ReformatBaseStream {
   }
 
   /// approx compression factor: e.g. mp3 is around 4
-  float getByteFactor() { return byte_factor; }
+  float getByteFactor() override { return byte_factor; }
   void setByteFactor(float factor) { byte_factor = factor; }
 
   /// defines the size of the decoded frame in bytes

src/AudioTools/AudioCodecs/CodecAACFDK.h

@@ -36,11 +36,11 @@ class AACDecoderFDK : public AudioDecoder  {
         }
 
         /// Defines the output stream
-        void setOutput(Print &out_stream){
+        void setOutput(Print &out_stream) override {
             dec->setOutput(out_stream);
         }
 
-        bool begin(){
+        bool begin() override {
             return dec->begin(TT_MP4_ADTS, 1);
         }
 
@@ -61,7 +61,7 @@ class AACDecoderFDK : public AudioDecoder  {
         }
 
         // write AAC data to be converted to PCM data
-        virtual size_t write(const uint8_t *data, size_t len) {
+        virtual size_t write(const uint8_t *data, size_t len) override {
             return dec->write(data, len);
         }
 
@@ -81,12 +81,12 @@ class AACDecoderFDK : public AudioDecoder  {
         }
 
         // release the resources
-        void end(){
+        void end() override {
              TRACED();
             dec->end();
         }
 
-        virtual operator bool() {
+        virtual operator bool() override  {
             return (bool)*dec;
         }
 
@@ -142,7 +142,7 @@ class AACEncoderFDK : public AudioEncoder {
      }
 
      /// Defines the output
-     void setOutput(Print &out_stream){
+     void setOutput(Print &out_stream) override {
          enc->setOutput(out_stream);
      }
 
@@ -253,7 +253,7 @@ class AACEncoderFDK : public AudioEncoder {
      * @param info 
      * @return int 
      */
-    virtual bool begin(AudioInfo info) {
+    virtual bool begin(AudioInfo info) override {
         TRACED();
         return enc->begin(info.channels,info.sample_rate, info.bits_per_sample);
     }
@@ -272,19 +272,19 @@ class AACEncoderFDK : public AudioEncoder {
     }
 
     // starts the processing
-    bool begin() {
+    bool begin() override {
         enc->begin();
         return true;
     }
 
     // convert PCM data to AAC
-    size_t write(const uint8_t *data, size_t len){
+    size_t write(const uint8_t *data, size_t len) override {
         LOGD("write %d bytes", (int)len);
         return enc->write((uint8_t*)data, len);
     }
 
     // release resources
-    void end(){
+    void end() override {
         TRACED();
         enc->end();
     }
@@ -301,11 +301,11 @@ class AACEncoderFDK : public AudioEncoder {
         return enc;
     }
 
-    const char *mime() {
+    const char *mime() override {
         return "audio/aac";
     }
 
-    operator bool(){
+    operator bool() override {
         return (bool) *enc;
     }
 

src/AudioTools/AudioCodecs/CodecAACHelix.h

@@ -75,7 +75,7 @@ class AACDecoderHelix : public AudioDecoder  {
         // }
 
         /// Defines the output Stream
-        virtual void setOutput(Print &out_stream){
+        virtual void setOutput(Print &out_stream) override {
             TRACED();
             AudioDecoder::setOutput(out_stream);
             if (aac!=nullptr) aac->setOutput(out_stream);

src/AudioTools/AudioCodecs/CodecMP3Helix.h

@@ -78,7 +78,7 @@ class MP3DecoderHelix : public AudioDecoder  {
         }
 
         /// Starts the processing
-        bool begin(){
+        bool begin() override {
             TRACED();
             if (mp3!=nullptr) {
                 //mp3->setDelay(CODEC_DELAY_MS);   
@@ -88,7 +88,7 @@ class MP3DecoderHelix : public AudioDecoder  {
         }
 
         /// Releases the reserved memory
-        void end(){
+        void end() override {
             TRACED();
             if (mp3!=nullptr) mp3->end();
         }
@@ -107,14 +107,14 @@ class MP3DecoderHelix : public AudioDecoder  {
         }
 
         /// Write mp3 data to decoder
-        size_t write(const uint8_t* data, size_t len) {
+        size_t write(const uint8_t* data, size_t len) override {
             LOGD("%s: %zu", LOG_METHOD, len);
             if (mp3==nullptr) return 0;
             return mp3->write((uint8_t*)data, len);
         }
 
         /// checks if the class is active 
-        operator bool(){
+        operator bool() override {
             return mp3!=nullptr && (bool) *mp3;
         }
 

src/AudioTools/AudioCodecs/CodecMP3MAD.h

@@ -44,7 +44,7 @@ class MP3DecoderMAD : public AudioDecoder  {
             delete mad;
         }
 
-        void setOutput(Print &out){
+        void setOutput(Print &out) override {
             TRACED();
             mad->setOutput(out);
         }
@@ -62,14 +62,14 @@ class MP3DecoderMAD : public AudioDecoder  {
         }
 
          /// Starts the processing
-        bool begin(){
+        bool begin() override {
             TRACED();
             mad->begin();
             return true;
         }
 
         /// Releases the reserved memory
-        void end(){
+        void end() override{
             TRACED();
             mad->end();
         }
@@ -91,7 +91,7 @@ class MP3DecoderMAD : public AudioDecoder  {
         }
 
         /// Makes the mp3 data available for decoding: however we recommend to provide the data via a callback or input stream
-        size_t write(const uint8_t *data, size_t len){
+        size_t write(const uint8_t *data, size_t len) override {
             TRACED();
             return mad->write(data,len);
         }
@@ -103,7 +103,7 @@ class MP3DecoderMAD : public AudioDecoder  {
         }
 
         /// Returns true as long as we are processing data
-        operator bool(){
+        operator bool() override{
             return (bool)*mad;
         }
 
@@ -123,7 +123,7 @@ class MP3DecoderMAD : public AudioDecoder  {
             }
         }
 
-        virtual void addNotifyAudioChange(AudioInfoSupport &bi) {
+        virtual void addNotifyAudioChange(AudioInfoSupport &bi) override {
             TRACED();
             audioChangeMAD = &bi;
             // register audio change handler

src/AudioTools/AudioCodecs/CodecWAV.h

@@ -71,7 +71,7 @@ class WAVHeader {
     headerInfo.bits_per_sample = read_int16();
     if (!setPos("data")) return false;
     headerInfo.data_length = read_int32();
-    if (!headerInfo.data_length==0 || headerInfo.data_length >= 0x7fff0000) {
+    if (headerInfo.data_length==0 || headerInfo.data_length >= 0x7fff0000) {
       headerInfo.is_streamed = true;
       headerInfo.data_length = ~0;
     }
@@ -128,7 +128,8 @@ class WAVHeader {
   }
 
   void dumpHeader() {
-    char msg[buffer.available()+1] = {0};
+    char msg[buffer.available()+1];
+    memset(msg, 0, buffer.available()+1);
     for (int j = 0; j< buffer.available();j++){
       char c = (char)buffer.data()[j];
       if (!isalpha(c)){

src/AudioTools/AudioCodecs/HeaderParserMP3.h

@@ -153,7 +153,7 @@ class HeaderParserMP3 {
               {0, 4, 8, 12, 16, 20, 24, 28, 32, 36, 40, 44, 48, 52, 56, -1},
           },
       };
-      signed char rate_byte = rateTable[AudioVersion][Layer][BitrateIndex];
+      signed char rate_byte = rateTable[(int)AudioVersion][(int)Layer][(int)BitrateIndex];
       if (rate_byte == -1) {
         LOGE("Unsupported bitrate");
         return 0;
@@ -178,7 +178,7 @@ class HeaderParserMP3 {
           {44100, 48000, 32000, 0},
       };
 
-      return rateTable[AudioVersion][SampleRateIndex];
+      return rateTable[(int)AudioVersion][(int)SampleRateIndex];
     }
 
     int getFrameLength() {

src/AudioTools/AudioCodecs/MultiDecoder.h

@@ -128,7 +128,7 @@ class MultiDecoder : public AudioDecoder {
     return actual_decoder.decoder->write(data, len);
   }
 
-  virtual operator bool() {
+  virtual operator bool() override {
     if (actual_decoder.decoder == &nop) return false;
     return is_first || actual_decoder.is_open;
   };

src/AudioTools/AudioLibs/AudioFFT.h

@@ -267,7 +267,7 @@ class AudioFFTBase : public AudioStream {
     }
   }
 
-  operator bool() { return p_driver != nullptr && p_driver->isValid(); }
+  operator bool() override { return p_driver != nullptr && p_driver->isValid(); }
 
   /// Notify change of audio information
   void setAudioInfo(AudioInfo info) override {