Fix broken type check

pschatzmann · pschatzmann · commit a7e62d4af2e3 · 2025-06-03T20:41:23.000+02:00
diff --git a/src/AudioTools/AudioCodecs/MP4Parser.h b/src/AudioTools/AudioCodecs/MP4Parser.h
@@ -310,7 +310,7 @@ class MP4Parser {
 
   bool isValidType(const char* type, int offset=0) const {
     // Check if the type is a valid 4-character string
-    return (type != nullptr && strlen(type) == 4 &&
+    return (type != nullptr &&
             isalnum(type[offset]) && isalnum(type[offset+1]) &&
             isalnum(type[offset+2]) && isalnum(type[offset+3]));
   }

Original file line number	Diff line number	Diff line change
`@@ -310,7 +310,7 @@ class MP4Parser {`
`310`	`310`
`311`	`311`	`bool isValidType(const char* type, int offset=0) const {`
`312`	`312`	`// Check if the type is a valid 4-character string`
`313`		`- return (type != nullptr && strlen(type) == 4 &&`
	`313`	`+ return (type != nullptr &&`
`314`	`314`	`isalnum(type[offset]) && isalnum(type[offset+1]) &&`
`315`	`315`	`isalnum(type[offset+2]) && isalnum(type[offset+3]));`
`316`	`316`	`}`