compile warnings

Author: pschatzmann

src/AudioAnalog/AnalogAudioESP32.h

@@ -193,7 +193,7 @@ class AnalogAudio  : public AudioStream {
       adc_config = cfg;
       i2s_config_t i2s_config = {
           .mode = (i2s_mode_t) cfg.mode_internal,
-          .sample_rate = (uint32_t)cfg.sample_rate,
+          .sample_rate = (eps32_i2s_sample_rate_type)cfg.sample_rate,
           .bits_per_sample = (i2s_bits_per_sample_t)16,
           .channel_format = I2S_CHANNEL_FMT_RIGHT_LEFT,
           .communication_format = (i2s_comm_format_t) I2S_COMM_FORMAT_STAND_I2S,

src/AudioConfig.h

@@ -175,6 +175,9 @@
 #if ESP_IDF_VERSION_MAJOR < 4 && !defined(I2S_COMM_FORMAT_STAND_I2S)
 # define I2S_COMM_FORMAT_STAND_I2S (I2S_COMM_FORMAT_I2S | I2S_COMM_FORMAT_I2S_LSB)
 # define I2S_COMM_FORMAT_STAND_MSB (I2S_COMM_FORMAT_I2S | I2S_COMM_FORMAT_I2S_MSB)
+typedef int eps32_i2s_sample_rate_type;
+#else
+typedef uint32_t eps32_i2s_sample_rate_type;
 #endif
 
 #endif

src/AudioEffects/AudioEffectsSuite.h

@@ -46,7 +46,7 @@ class ModulationBaseClass {
   ModulationBaseClass() { srand(static_cast<unsigned>(time(0))); }
 
   ModulationBaseClass(effectsuite_t extSampRate) {
-    sampleRate = extSampRate;
+    this->sampleRate = extSampRate;
     timeStep = 1. / extSampRate;
     allocateMemory();
     // setInterpTable();
@@ -975,9 +975,10 @@ class SimpleChorus : public DelayEffectBase,
    * delay buffer size when initialisi.
    */
   SimpleChorus() : SimpleLPF(0.0001, 4) {}
-  SimpleChorus(int extSampleRate=44100)
-      : ModulationBaseClass(extSampleRate),
-        DelayEffectBase(effectsuite_t(extSampleRate) * .031), SimpleLPF(0.0001, 4) {
+  SimpleChorus(int extSampleRate=44100) :
+        DelayEffectBase(static_cast<int>(0.031 * extSampleRate)), 
+        ModulationBaseClass(extSampleRate),
+        SimpleLPF(0.0001, 4) {
     swing = 0.005 * sampleRate;
     base = 0.015 * sampleRate;
     if (sampleRate != 0)

src/AudioExperiments/AudioExperiments.h

@@ -1,5 +1,7 @@
 #pragma once
 
+#ifdef USE_EXPERIMENTS
 #include "AudioExperiments/AudioDAC.h"
 #include "AudioExperiments/AudioUSB.h"
 //#include "AudioExperiments/TimerCallbackAudioStream.h"
+#endif

src/AudioI2S/I2SESP32.h

@@ -43,16 +43,16 @@ class I2SBase {
 
       i2s_config_t i2s_config_new = {
             .mode = toMode(cfg),
-            .sample_rate = (uint32_t)cfg.sample_rate,
+            .sample_rate = (eps32_i2s_sample_rate_type)cfg.sample_rate,
             .bits_per_sample = (i2s_bits_per_sample_t) cfg.bits_per_sample,
             .channel_format = I2S_CHANNEL_FMT_RIGHT_LEFT,
             .communication_format = toCommFormat(cfg.i2s_format),
             .intr_alloc_flags = ESP_INTR_FLAG_LEVEL1, // default interrupt priority
             .dma_buf_count = I2S_BUFFER_COUNT,
             .dma_buf_len = I2S_BUFFER_SIZE,
-            .use_apll = cfg.use_apll,
+            .use_apll = (bool) cfg.use_apll,
             .tx_desc_auto_clear = I2S_AUTO_CLEAR, 
-            .fixed_mclk = cfg.use_apll ? cfg.sample_rate * cfg.apll_frequency_factor : 0 
+            .fixed_mclk = (eps32_i2s_sample_rate_type) (cfg.use_apll ? cfg.sample_rate * cfg.apll_frequency_factor : 0 )
 
       };
       i2s_config = i2s_config_new;

src/AudioMetaData/AbstractMetaData.h

@@ -21,6 +21,8 @@ const char *toStr(MetaDataType t){
  */
 class AbstractMetaData {
     public:
+        virtual  ~AbstractMetaData() = default;
+
         // defines the callback which provides the metadata information
         virtual void setCallback(void (*fn)(MetaDataType info, const char* str, int len)) = 0 ;
         // starts the processing

src/AudioMetaData/MetaData.h

@@ -56,7 +56,7 @@ class MetaDataPrint : public AudioPrint {
     }
 
     virtual void end() {
-        if (callback!=nullptr & meta != nullptr) {
+        if (callback!=nullptr && meta != nullptr) {
             LOGD(LOG_METHOD);
             meta->end();
         }

src/AudioTimer/AudioTimerDef.h

@@ -13,6 +13,7 @@ enum TimerFunction {DirectTimerCallback, TimerCallbackInThread, SimpleThreadLoop
  */
 class TimerAlarmRepeatingDef {
     public:
+        virtual  ~TimerAlarmRepeatingDef() = default;
         virtual bool begin(repeating_timer_callback_t callback_f, uint32_t time, TimeUnit unit = MS) = 0;
         virtual bool end() = 0;
 

src/AudioTools/AudioStreams.h

@@ -705,7 +705,6 @@ class TimerCallbackAudioStream : public BufferedStream, public AudioBaseInfoSour
             if (lastTimestamp>0u){
                 uint32_t diff = ms-lastTimestamp; 
                 if (diff>0){
-                    uint16_t bytes_per_sample = cfg.bits_per_sample/8;
                     uint16_t rate = 1 * 1000 / diff; 
 
                     if (currentRateValue==0){

src/AudioTools/SoundGenerator.h

@@ -78,7 +78,7 @@ class SoundGenerator  {
 
         virtual AudioBaseInfo defaultConfig(){
             AudioBaseInfo def;
-            def.bits_per_sample!=sizeof(T)*8;
+            def.bits_per_sample = sizeof(T)*8;
             def.channels = 1;
             def.sample_rate = 44100;
             return def;