RP2040 BaseStream correct read() empty to -1

pschatzmann · pschatzmann · commit bca62a5a1cfb · 2025-01-06T20:24:47.000+01:00
diff --git a/src/AudioTools/CoreAudio/BaseStream.h b/src/AudioTools/CoreAudio/BaseStream.h
@@ -72,11 +72,15 @@ class BaseStream : public Stream {
 
   virtual int read() override {
     refillReadBuffer();
+    // if it is empty we need to return an int -1
+    if (tmp_in.isEmpty()) return -1;
     return tmp_in.read();
   }
 
   virtual int peek() override {
     refillReadBuffer();
+    // if it is empty we need to return an int -1
+    if (tmp_in.isEmpty()) return -1;
     return tmp_in.peek();
   }
 

Original file line number	Diff line number	Diff line change
`@@ -72,11 +72,15 @@ class BaseStream : public Stream {`
`72`	`72`
`73`	`73`	`virtual int read() override {`
`74`	`74`	`refillReadBuffer();`
	`75`	`+ // if it is empty we need to return an int -1`
	`76`	`+ if (tmp_in.isEmpty()) return -1;`
`75`	`77`	`return tmp_in.read();`
`76`	`78`	`}`
`77`	`79`
`78`	`80`	`virtual int peek() override {`
`79`	`81`	`refillReadBuffer();`
	`82`	`+ // if it is empty we need to return an int -1`
	`83`	`+ if (tmp_in.isEmpty()) return -1;`
`80`	`84`	`return tmp_in.peek();`
`81`	`85`	`}`
`82`	`86`