RTSPServer: session timeout

Author: pschatzmann

src/AudioTools/AudioCodecs/AudioCodecsBase.h

@@ -107,9 +107,9 @@ class AudioEncoder : public AudioWriter {
   AudioInfo audioInfo() override { return info; }
   /// Default output assignment (encoders may override to store Print reference)
   virtual void setOutput(Print &out_stream) override { (void)out_stream; }
-  /// Optioinal rtsp function: provide the frame duration in microseconds
+  /// Optional rtsp function: provide the frame duration in microseconds
   virtual uint32_t frameDurationUs() { return 0;};
-  /// Optioinal rtsp function: provide samples per the frame
+  /// Optional rtsp function: provide samples per the frame
   virtual uint16_t samplesPerFrame() { return 0;};
 
  protected:

src/AudioTools/Communication/RTSP/RTSPServer.h

@@ -142,12 +142,30 @@ class RTSPServer {
     return ok;
   }
 
+
+  /**
+   * @brief Get the server task handle
+   * @return Reference to the server task
+   */
   audio_tools::Task& getTaskHandle() { return serverTask; };
 
+  /**
+   * @brief Get the number of connected clients
+   * @return Number of clients
+   */
   int clientCount() { return client_count;}
 
+  /**
+   * @brief Returns true if there is at least one connected client
+   */
   operator bool() { return client_count > 0;}
 
+  /**
+   * @brief Set the session timeout in milliseconds
+   * @param ms Timeout in milliseconds
+   */
+  void setSessionTimoutMs(unsigned long ms){ sessionTimeoutMs = ms;}
+
  protected:
   int port;  // port that the RTSP Server listens on
   int core;  // the core number the RTSP runs on (platform-specific)
@@ -160,6 +178,7 @@ class RTSPServer {
                                    // source for data streams
   bool (*onSessionPathCb)(const char*, void*) = nullptr; // session path callback
   void* onSessionPathRef = nullptr;
+  unsigned long sessionTimeoutMs = 20000; // 20 seconds
 
   /**
    * @brief Start RTSP server asynchronously
@@ -277,12 +296,26 @@ class RTSPServer {
 
     LOGI("Session ready");
 
+
+    // Session timeout logic
+    unsigned long lastRequestTime = millis();
+
     while (rtsp->isSessionOpen()) {
       uint32_t timeout = 30;
-      if (!rtsp->handleRequests(timeout)) {
-        LOGI("Request handling timed out or no data yet");
-      } else {
+      bool gotRequest = rtsp->handleRequests(timeout);
+      if (gotRequest) {
+        lastRequestTime = millis();
         LOGD("Request handling successful");
+      } else {
+        LOGI("Request handling timed out or no data yet");
+      }
+
+      // If streaming, check for session timeout
+      if (rtsp->isStreaming()) {
+        if ((millis() - lastRequestTime) > sessionTimeoutMs) {
+          LOGW("Session timeout: no client request received for 20 seconds, closing session");
+          break;
+        }
       }
 
       int time = timeout - (millis() - lastCheck);