AudioSources: fix memory leaks

Author: pschatzmann

src/AudioTools/Disk/AudioSourceSD.h

@@ -72,6 +72,7 @@ class AudioSourceSD : public AudioSource {
   }
 
   void end() {
+    file.close();
     SD.end();
     is_sd_setup = false;
   }

src/AudioTools/Disk/AudioSourceSDFAT.h

@@ -87,6 +87,8 @@ class AudioSourceSDFAT : public AudioSource {
   }
 
   void end() {
+    file.close();
+
     if (is_sd_setup) {
       TRACEI();
 #ifdef ESP32

src/AudioTools/Disk/AudioSourceSDMMC.h

@@ -53,6 +53,7 @@ class AudioSourceSDMMC : public AudioSource {
   }
 
   void end() {
+    file.close();
     SD_MMC.end();
     is_sd_setup = false;
   }
@@ -65,6 +66,7 @@ class AudioSourceSDMMC : public AudioSource {
 
   virtual Stream *selectStream(int index) override {
     LOGI("selectStream: %d", index);
+    file.close();
     idx_pos = index;
     file_name = idx[index];
     if (file_name==nullptr) return nullptr;

src/AudioTools/Disk/AudioSourceSPIFFS.h

@@ -40,6 +40,7 @@ class AudioSourceSPIFFS : public AudioSource {
   }
 
   void end() {
+    file.close();
     SPIFFS.end();
     is_sd_setup = false;
   }
@@ -51,6 +52,7 @@ class AudioSourceSPIFFS : public AudioSource {
 
   virtual Stream *selectStream(int index) override {
     LOGI("selectStream: %d", index);
+    file.close();
     idx_pos = index;
     file_name = idx[index];
     if (file_name==nullptr) return nullptr;

src/AudioTools/Disk/AudioSourceSTD.h

@@ -32,6 +32,7 @@ class AudioSourceSTD : public AudioSource {
   }
 
   virtual void end() {
+    file.close();
   }
 
   virtual Stream *nextStream(int offset = 1) override {

src/AudioTools/Disk/AudioSourceVFS.h

@@ -43,6 +43,7 @@ class AudioSourceVFS : public AudioSource {
   }
 
   virtual void end() {
+    file.close();
     if (p_vfs) p_vfs->end();
   }
 
@@ -64,6 +65,10 @@ class AudioSourceVFS : public AudioSource {
 
   virtual Stream *selectStream(const char *path) override {
     file.close();
+    if (path == nullptr) {
+      LOGE("Filename is null")
+      return nullptr;
+    }
     assert(p_vfs != nullptr);
     file = p_vfs->open(path);
     file_name = file.name();