fix a bunch of warnings and add headers

Author: pschichtel

core-test/src/test/java/tel/schich/javacan/test/BcmCanSocketTest.java

@@ -113,9 +113,7 @@ void testMessageFrameAccess() {
             assertArrayEquals(frameData[i], dataBuffer.array());
         }
         // check no frame after the last index
-        assertThrows(IllegalArgumentException.class, () -> {
-            message.getFrame(frameData.length);
-        });
+        assertThrows(IllegalArgumentException.class, () -> message.getFrame(frameData.length));
     }
 
     @Test
@@ -151,9 +149,7 @@ void testMessageFDFrameAccess() {
             assertArrayEquals(frameData[i], dataBuffer.array());
         }
         // check no frame after the last index
-        assertThrows(IllegalArgumentException.class, () -> {
-            message.getFrame(frameData.length);
-        });
+        assertThrows(IllegalArgumentException.class, () -> message.getFrame(frameData.length));
     }
 
     @Test

core-test/src/test/java/tel/schich/javacan/test/RawCanSocketTest.java

@@ -26,7 +26,6 @@
 import tel.schich.javacan.CanChannels;
 import tel.schich.javacan.CanFilter;
 import tel.schich.javacan.CanFrame;
-import tel.schich.javacan.CanSocketOptions;
 import tel.schich.javacan.JavaCAN;
 import tel.schich.javacan.RawCanChannel;
 import tel.schich.javacan.platform.linux.LinuxNativeOperationException;
@@ -123,6 +122,7 @@ void testFilters() throws Exception {
         }
     }
 
+    @Test
     void testMaxFilterValidation() throws Exception {
         try (final RawCanChannel socket = CanChannels.newRawChannel()) {
             socket.bind(CAN_INTERFACE);

epoll-test/src/test/java/tel/schich/javacan/test/select/EPollSelectorTest.java

@@ -67,9 +67,7 @@ public void testWriteRead() throws IOException {
                 selector.register(ch, EnumSet.of(SelectorRegistration.Operation.READ));
 
                 CanFrame inputFrame = CanFrame.create(0x7EF, FD_NO_FLAGS, new byte[]{1, 2, 3, 4});
-                runDelayed(ofMillis(200), () -> {
-                    ch.write(inputFrame);
-                });
+                runDelayed(ofMillis(200), () -> ch.write(inputFrame));
                 assertTimeoutPreemptively(ofMillis(300), () -> {
                     List<IOEvent<UnixFileDescriptor>> events = selector.select();
                     assertEquals(1, events.size(), "With one registered channel there should only be one selection key!");
@@ -109,7 +107,7 @@ public void testEPollFdReuse() throws IOException, InterruptedException {
         try (final EPollSelector selector = EPollSelector.open()) {
 
             SelectorRegistration<UnixFileDescriptor, RawCanChannel> firstRegistration = configureAndRegisterChannel(selector);
-            try (RawCanChannel firstChannel = firstRegistration.getChannel()) {
+            try (RawCanChannel ignored = firstRegistration.getChannel()) {
                 CanTestHelper.sendFrameViaUtils(CAN_INTERFACE, CanFrame.create(0x3, CanFrame.FD_NO_FLAGS, new byte[] {1}));
                 assertEquals(1, selector.selectNow().size());
 

epoll-test/src/test/java/tel/schich/javacan/test/util/CanBrokerTest.java

@@ -22,7 +22,6 @@
  */
 package tel.schich.javacan.test.util;
 
-import org.junit.Assert;
 import org.junit.jupiter.api.Test;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -37,8 +36,7 @@
 import java.util.concurrent.ThreadFactory;
 
 import static java.util.concurrent.TimeUnit.SECONDS;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.*;
 
 class CanBrokerTest {
     private static final Logger LOGGER = LoggerFactory.getLogger(CanBrokerTest.class);
@@ -67,13 +65,11 @@ void testLoopback() throws Exception {
             try {
                 brokerA.removeDevice(CanTestHelper.CAN_INTERFACE);
             } catch (IOException e) {
-                Assert.fail("Removing the device from brokerA should not fail: " + e.getLocalizedMessage());
+                fail("Removing the device from brokerA should not fail: " + e.getLocalizedMessage());
             }
         });
 
-        brokerB.addDevice(CanTestHelper.CAN_INTERFACE, (d, frame) -> {
-            LOGGER.debug(String.valueOf(frame));
-        });
+        brokerB.addDevice(CanTestHelper.CAN_INTERFACE, (d, frame) -> LOGGER.debug(String.valueOf(frame)));
         brokerB.send(expected);
 
         CanFrame actual = f.get(2, SECONDS);
@@ -91,9 +87,7 @@ void testExternal() throws Exception {
 
         CanBroker can = new CanBroker(FACTORY, EPollSelector.open());
         can.addFilter(new CanFilter(id));
-        can.addDevice(CanTestHelper.CAN_INTERFACE, (ch, frame) -> {
-            f.complete(frame);
-        });
+        can.addDevice(CanTestHelper.CAN_INTERFACE, (ch, frame) -> f.complete(frame));
 
         CanTestHelper.sendFrameViaUtils(CanTestHelper.CAN_INTERFACE, expected);
 

epoll-test/src/test/java/tel/schich/javacan/test/util/IsotpListenerTest.java

@@ -61,7 +61,6 @@ void testBroker() throws Exception {
         IsotpSocketAddress addrb = IsotpSocketAddress.isotpAddress(SFF_ECU_RESPONSE_BASE + DESTINATION_ECU_1);
 
         try (IsotpListener broker = new IsotpListener(threadFactory, EPollSelector.open(), Duration.ofSeconds(5))) {
-
             try (IsotpCanChannel a = CanChannels.newIsotpChannel()) {
                 try (IsotpCanChannel b = CanChannels.newIsotpChannel()) {
                     final ByteBuffer buf = IsotpCanChannel.allocateSufficientMemory();
@@ -74,8 +73,8 @@ void testBroker() throws Exception {
                     broker.addChannel(a, new PingPing(lock, condition, buf));
                     broker.addChannel(b, new PingPing(lock, condition, buf));
 
-                    buf.put(randomByte())
-                            .flip();
+                    buf.put(randomByte());
+                    buf.flip();
                     a.write(buf);
 
                     try {

epoll/src/main/java/tel/schich/javacan/util/CopyingFrameHandlerProxy.java

@@ -1,3 +1,25 @@
+/*
+ * The MIT License
+ * Copyright © 2018 Phillip Schichtel
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
 package tel.schich.javacan.util;
 
 import tel.schich.javacan.CanFrame;

epoll/src/main/java/tel/schich/javacan/util/CopyingMessageHandlerProxy.java

@@ -1,3 +1,25 @@
+/*
+ * The MIT License
+ * Copyright © 2018 Phillip Schichtel
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
 package tel.schich.javacan.util;
 
 import tel.schich.javacan.IsotpCanChannel;