Skip to content

Commit 79d0802

Browse files
committed
simplify no_store test as per comment of @jaap3
1 parent a954e24 commit 79d0802

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

tests/test_cache_control.py

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -115,21 +115,11 @@ def test_cache_response_no_store(self):
115115
cc.cache_response(self.req(), resp)
116116
assert not cc.cache.get(cache_url)
117117

118-
def test_cache_response_no_store_with_etag(self):
119-
resp = Mock()
120-
cache = DictCache({self.url: resp})
121-
cc = CacheController(cache)
122-
123-
cache_url = cc.cache_url(self.url)
124-
118+
def test_cache_response_no_store_with_etag(self, cc):
125119
resp = self.resp({'cache-control': 'no-store', 'ETag': 'jfd9094r808'})
126-
assert cc.cache.get(cache_url)
127-
128-
# skip serializer as it can't handle mocks
129-
cc.serializer = Mock()
130-
cc.serializer.loads.return_value = resp
131120
cc.cache_response(self.req(), resp)
132-
assert not cc.cache.get(cache_url)
121+
122+
assert not cc.cache.set.called
133123

134124
def test_update_cached_response_with_valid_headers(self):
135125
cached_resp = Mock(headers={'ETag': 'jfd9094r808', 'Content-Length': 100})

0 commit comments

Comments
 (0)