Skip to content

Fix: Mitigate urllib3 IPv6 Zone ID parsing bug #7088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexciechonski wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Fix: Mitigate urllib3 IPv6 Zone ID parsing bug #7088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/requests/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,18 @@ def prepare_url(self, url, params):
# Support for unicode domain names and paths.
try:
scheme, auth, host, port, path, query, fragment = parse_url(url)

# Bug mitigation for RFC 6874: parse_url incorrectly decodes the zone ID delimiter (%25 -> %).
# We reconstruct the host with the correct, fully-encoded delimiter to prevent
# downstream errors (like the ipaddress validation or incorrect connection arguments).

if host and host.startswith('[') and host.endswith(']') and host.count('%') == 1:

# Extract the Zone ID, which is the part after the single %
host_ip_with_zone = host.strip('[]')
host_ip, zone_id = host_ip_with_zone.split('%', 1)
host = f'[{host_ip}%25{zone_id}]'

except LocationParseError as e:
raise InvalidURL(*e.args)

Expand Down