Fix handling of zero and empty cookie values in RequestsCookieJar #7103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses a bug in the _find_no_duplicates method of RequestsCookieJar where cookies with values of 0 or empty strings ('') were not being returned correctly.
Changes included:
Updated _find_no_duplicates to correctly return cookie values that are 0 or ''.
Added and updated test cases in test_cookie.py to cover:
-Cookies with value 0
-Cookies with empty string value
-Cookies with None value
-Cookies with domain and path matching
-Overwriting cookies with zero values
-Persistence of zero values after update
These changes ensure that the get method and other functions depending on _find_no_duplicates behave correctly for all valid cookie values.
Impact:
Existing code that relies on _find_no_duplicates returning cookie.value is preserved.