Merge pull request #50 from pskd73/fix/Fixing_list_field_validate_dict_assertion

Fix list field validate dict assertion

Author: sameer-639

pydictable/field.py

@@ -120,15 +120,15 @@ def to_dict(self, v, skip_optional: bool = False):
         return [self.obj_type.to_dict(e, skip_optional) for e in v]
 
     def validate_dict(self, field_name: str, v):
-        assert type(v) == list
+        assert isinstance(v, list)
         for i, _val in enumerate(v):
             try:
                 self.obj_type.validate_dict(field_name, _val)
             except AssertionError as e:
                 raise DataValidationError(f'[{i}]', str(e))
 
     def validate(self, field_name: str, v):
-        assert type(v) == list
+        assert isinstance(v, list)
         [self.obj_type.validate(field_name, x) for x in v]
 
     def of(self):

pydictable/test_field.py

@@ -1,6 +1,5 @@
 from unittest import TestCase
-
-from pydictable import DictField, StrField, DataValidationError, DictAble, ObjectField, UnionField
+from pydictable import DictField, StrField, DataValidationError, DictAble, ObjectField, UnionField, ListField
 
 
 class TestField(TestCase):
@@ -59,3 +58,28 @@ class Rule(DictAble):
 
         r = Rule(dict={'expression': {'expression': 'nested'}})
         self.assertEqual(r.expression.expression, 'nested')
+
+    def test_list_field(self):
+        class MyList(list):
+            pass
+
+        class MyListField(ListField):
+            def validate_dict(self, field_name: str, v):
+                super(MyListField, self).validate_dict(field_name, v)
+                assert type(v) == list
+
+            def validate(self, field_name: str, v):
+                super(MyListField, self).validate(field_name, v)
+                assert type(v) == list
+
+        my_list = MyList(['A', 'B'])
+
+        field = MyListField(StrField())
+        self.assertRaises(AssertionError, lambda: field.validate_dict('x', my_list))
+        self.assertRaises(AssertionError, lambda: field.validate('x', my_list))
+
+        field = ListField(StrField())
+        field.validate_dict('x', my_list)
+        field.validate('x', my_list)
+        field.validate_dict('x', list(['A', 'B']))
+        field.validate('x', list(['A', 'B']))

setup.py

@@ -2,7 +2,7 @@
 
 setuptools.setup(
     name='pydictable',
-    version='2.2.0',
+    version='2.3.0',
     author='Pramod Kumar',
     author_email='pramodkumar.damam73@gmail.com',
     description='Make your classes from/to dict',