Skip to content

Commit 7408de7

Browse files
ajkiessljrpatterson
ajkiessl
and
jrpatterson
authored
Honors admin name change (#588)
* Updated contact info requested by Sarah * Approval status threshold tests were failing because the threshold wasn't being met. Not sure why it suddenly stopped working, however the test was set up to be on the threshold exactly. I changed this with an hour of padding so there isn't some rounding error that might make it fail. Co-authored-by: Justin Patterson <jrp22@psu.edu>
1 parent f6842e2 commit 7408de7

File tree

2 files changed

+29
-46
lines changed

2 files changed

+29
-46
lines changed

‎config/locales/partners/en/honors/honors.en.yml‎

Lines changed: 17 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,8 @@ en:
3737
Sincerely,
3838
The Schreyer Honors College
3939
If you have any further questions please contact:  
40-
Debra Rodgers, Coordinator of Academic Services 
40+
Sarah Richards, Coordinator of Student Records & Advising Services
4141
SHCAcademics@psu.edu
42-
814-867-2505
4342
final_submission_approved:
4443
message: |
4544
Your honors %{degree_type} has been approved by Schreyer Honors College.    
@@ -52,9 +51,8 @@ en:
5251
Sincerely,
5352
The Schreyer Honors College
5453
If you have any further questions please contact:  
55-
Debra Rodgers, Coordinator of Academic Services 
54+
Sarah Richards, Coordinator of Student Records & Advising Services
5655
SHCAcademics@psu.edu 
57-
814-867-2505
5856
format_review_received:
5957
message: |
6058
Thank you for submitting your %{degree_type} for format review. Our staff will be in touch with
@@ -64,9 +62,8 @@ en:
6462
Sincerely,
6563
The Schreyer Honors College
6664
If you have any further questions please contact:  
67-
Debra Rodgers, Coordinator of Academic Services 
65+
Sarah Richards, Coordinator of Student Records & Advising Services
6866
SHCAcademics@psu.edu 
69-
814-867-2505
7067
final_submission_received:
7168
message: |
7269
Thank you for submitting your final %{degree_type}. It will now be automatically sent to your committee for review and approval.
@@ -75,9 +72,8 @@ en:
7572
Sincerely,
7673
The Schreyer Honors College
7774
If you have any further questions please contact:  
78-
Debra Rodgers, Coordinator of Academic Services 
75+
Sarah Richards, Coordinator of Student Records & Advising Services
7976
SHCAcademics@psu.edu
80-
814-867-2505
8177
sent_to_committee:
8278
message: |
8379
Your %{degree_type}: "%{title}" has been sent back to the committee review stage to be approved by your committee.
@@ -87,9 +83,8 @@ en:
8783
Sincerely,
8884
The Schreyer Honors College
8985
If you have any further questions please contact:  
90-
Debra Rodgers, Coordinator of Academic Services 
86+
Sarah Richards, Coordinator of Student Records & Advising Services
9187
SHCAcademics@psu.edu
92-
814-867-2505
9388
committee_member_review_requested:
9489
message: |
9590
Hello %{committee_member_name},
@@ -100,9 +95,8 @@ en:
10095
Sincerely,
10196
The Schreyer Honors College
10297
If you have any further questions please contact:  
103-
Debra Rodgers, Coordinator of Academic Services 
98+
Sarah Richards, Coordinator of Student Records & Advising Services
10499
SHCAcademics@psu.edu
105-
814-867-2505
106100
special_committee_review_request:
107101
message: |
108102
Hello %{committee_member_name},
@@ -116,9 +110,8 @@ en:
116110
Sincerely,
117111
The Schreyer Honors College
118112
If you have any further questions please contact:  
119-
Debra Rodgers, Coordinator of Academic Services 
113+
Sarah Richards, Coordinator of Student Records & Advising Services
120114
SHCAcademics@psu.edu
121-
814-867-2505
122115
committee_member_review_reminder:
123116
message: |
124117
Reminder: %{full_name} has submitted their %{degree_type} entitled %{title} for final review.
@@ -128,9 +121,8 @@ en:
128121
Sincerely,
129122
The Schreyer Honors College
130123
If you have any further questions please contact:  
131-
Debra Rodgers, Coordinator of Academic Services 
124+
Sarah Richards, Coordinator of Student Records & Advising Services
132125
SHCAcademics@psu.edu
133-
814-867-2505
134126
committee_rejected_admin:
135127
message: |
136128
The committee for %{author_name}'s %{degree_type} has rejected their submission.
@@ -139,9 +131,8 @@ en:
139131
Sincerely,
140132
The Schreyer Honors College
141133
If you have any further questions please contact:  
142-
Debra Rodgers, Coordinator of Academic Services 
134+
Sarah Richards, Coordinator of Student Records & Advising Services
143135
SHCAcademics@psu.edu
144-
814-867-2505
145136
committee_rejected_author:
146137
message: |
147138
The committee reviewing your %{degree_type} has rejected your submission.
@@ -152,9 +143,8 @@ en:
152143
Sincerely,
153144
The Schreyer Honors College
154145
If you have any further questions please contact:  
155-
Debra Rodgers, Coordinator of Academic Services 
146+
Sarah Richards, Coordinator of Student Records & Advising Services
156147
SHCAcademics@psu.edu
157-
814-867-2505
158148
committee_rejected_committee:
159149
message: |
160150
%{author_name}'s %{degree_type} titled "%{title}" has been rejected by its committee.
@@ -163,9 +153,8 @@ en:
163153
Sincerely,
164154
The Schreyer Honors College
165155
If you have any further questions please contact:  
166-
Debra Rodgers, Coordinator of Academic Services 
156+
Sarah Richards, Coordinator of Student Records & Advising Services
167157
SHCAcademics@psu.edu
168-
814-867-2505
169158
pending_returned_author:
170159
message: |
171160
Your %{degree_type} has been rejected by request of an administrator.
@@ -174,9 +163,8 @@ en:
174163
Sincerely,
175164
The Schreyer Honors College
176165
If you have any further questions please contact:  
177-
Debra Rodgers, Coordinator of Academic Services 
166+
Sarah Richards, Coordinator of Student Records & Advising Services
178167
SHCAcademics@psu.edu
179-
814-867-2505
180168
pending_returned_committee:
181169
message: |
182170
%{author_name}'s eTD submission titled "%{title}" has been rejected at the request of an administrator.
@@ -185,9 +173,8 @@ en:
185173
Sincerely,
186174
The Schreyer Honors College
187175
If you have any further questions please contact:  
188-
Debra Rodgers, Coordinator of Academic Services 
176+
Sarah Richards, Coordinator of Student Records & Advising Services
189177
SHCAcademics@psu.edu
190-
814-867-2505
191178
committee_approved:
192179
message: |
193180
Congratulations! Your honors %{degree_type} has been reviewed by your committee and it is approved.
@@ -196,9 +183,8 @@ en:
196183
Sincerely,
197184
The Schreyer Honors College
198185
If you have any further questions please contact:  
199-
Debra Rodgers, Coordinator of Academic Services 
186+
Sarah Richards, Coordinator of Student Records & Advising Services
200187
SHCAcademics@psu.edu
201-
814-867-2505
202188
release_for_publication:
203189
message: |
204190
Your %{degree_type} titled "%{title}" has been released with the access level of Open Access.
@@ -207,9 +193,8 @@ en:
207193
Sincerely,
208194
The Schreyer Honors College
209195
If you have any further questions please contact:  
210-
Debra Rodgers, Coordinator of Academic Services 
196+
Sarah Richards, Coordinator of Student Records & Advising Services
211197
SHCAcademics@psu.edu
212-
814-867-2505
213198
release_for_publication_metadata_only:
214199
message: |
215200
The metadata for your %{degree_type} titled "%{title}" has been released.
@@ -219,9 +204,8 @@ en:
219204
Sincerely,
220205
The Schreyer Honors College
221206
If you have any further questions please contact:  
222-
Debra Rodgers, Coordinator of Academic Services 
207+
Sarah Richards, Coordinator of Student Records & Advising Services
223208
SHCAcademics@psu.edu
224-
814-867-2505
225209
access_level_updated:
226210
message: |
227211
The Schreyer Honors College has changed the availability of the following honor thesis as shown below:
@@ -234,9 +218,8 @@ en:
234218
Sincerely,
235219
The Schreyer Honors College
236220
If you have any further questions please contact:  
237-
Debra Rodgers, Coordinator of Academic Services 
221+
Sarah Richards, Coordinator of Student Records & Advising Services
238222
SHCAcademics@psu.edu
239-
814-867-2505
240223
program:
241224
label: Area of Honors
242225
committee:

‎spec/models/approval_status_spec.rb‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -451,22 +451,22 @@
451451
submission: submission,
452452
status: 'approved',
453453
is_voting: true,
454-
approval_started_at: (DateTime.now - 7.days))
454+
approval_started_at: (DateTime.now - (7.days + 1.hour)))
455455
submission.committee_members << FactoryBot.create(:committee_member, :review_started,
456456
submission: submission,
457457
status: 'approved',
458458
is_voting: true,
459-
approval_started_at: (DateTime.now - 7.days))
459+
approval_started_at: (DateTime.now - (7.days + 1.hour)))
460460
submission.committee_members << FactoryBot.create(:committee_member, :review_started,
461461
submission: submission,
462462
status: 'approved',
463463
is_voting: true,
464-
approval_started_at: (DateTime.now - 7.days))
464+
approval_started_at: (DateTime.now - (7.days + 1.hour)))
465465
submission.committee_members << FactoryBot.create(:committee_member, :review_started,
466466
submission: submission,
467467
status: '',
468468
is_voting: true,
469-
approval_started_at: (DateTime.now - 7.days))
469+
approval_started_at: (DateTime.now - (7.days + 1.hour)))
470470

471471
expect(described_class.new(submission).status).to eq('approved')
472472
end
@@ -478,22 +478,22 @@
478478
submission: submission,
479479
status: 'approved',
480480
is_voting: true,
481-
approval_started_at: (DateTime.now - 7.days))
481+
approval_started_at: (DateTime.now - (7.days + 1.hour)))
482482
submission.committee_members << FactoryBot.create(:committee_member, :review_started,
483483
submission: submission,
484484
status: 'approved',
485485
is_voting: true,
486-
approval_started_at: (DateTime.now - 7.days))
486+
approval_started_at: (DateTime.now - (7.days + 1.hour)))
487487
submission.committee_members << FactoryBot.create(:committee_member, :review_started,
488488
submission: submission,
489489
status: 'approved',
490490
is_voting: true,
491-
approval_started_at: (DateTime.now - 7.days))
491+
approval_started_at: (DateTime.now - (7.days + 1.hour)))
492492
submission.committee_members << FactoryBot.create(:committee_member, :review_started,
493493
submission: submission,
494494
status: 'rejected',
495495
is_voting: true,
496-
approval_started_at: (DateTime.now - 7.days))
496+
approval_started_at: (DateTime.now - (7.days + 1.hour)))
497497

498498
expect(described_class.new(submission).status).to eq('approved')
499499
end
@@ -505,22 +505,22 @@
505505
submission: submission,
506506
status: 'approved',
507507
is_voting: true,
508-
approval_started_at: (DateTime.now - 7.days))
508+
approval_started_at: (DateTime.now - (7.days + 1.hour)))
509509
submission.committee_members << FactoryBot.create(:committee_member, :review_started,
510510
submission: submission,
511511
status: 'approved',
512512
is_voting: true,
513-
approval_started_at: (DateTime.now - 7.days))
513+
approval_started_at: (DateTime.now - (7.days + 1.hour)))
514514
submission.committee_members << FactoryBot.create(:committee_member, :review_started,
515515
submission: submission,
516516
status: '',
517517
is_voting: true,
518-
approval_started_at: (DateTime.now - 7.days))
518+
approval_started_at: (DateTime.now - (7.days + 1.hour)))
519519
submission.committee_members << FactoryBot.create(:committee_member, :review_started,
520520
submission: submission,
521521
status: 'rejected',
522522
is_voting: true,
523-
approval_started_at: (DateTime.now - 7.days))
523+
approval_started_at: (DateTime.now - (7.days + 1.hour)))
524524

525525
expect(described_class.new(submission).status).to eq('pending')
526526
end

0 commit comments

Comments
 (0)