refactor tests

Author: Smullz622

spec/integration/admin/submissions/admin_access_level_spec.rb

@@ -55,18 +55,24 @@
     end
 
     context 'when author is in college of liberal arts' do
-      unless current_partner.milsch?
-        before do
-          submission.update(academic_program: 'LA')
-          page.refresh
-        end
+      before do
+        submission.update(academic_program: 'LA')
+        page.refresh
+      end
 
+      if current_partner.graduate?
         it 'has a restricted_liberal_arts radio button' do
           page.find("input#submission_access_level_restricted_liberal_arts").click
           expect(page.find("input#submission_access_level_restricted_liberal_arts")).to be_checked
           expect(page).to have_field('submission_invention_disclosures_attributes_0_id_number')
         end
       end
+
+      unless current_partner.graduate?
+        it 'does not have a restricted_liberal_arts radio button' do
+          expect(page).not_to have_selector("input#submission_access_level_restricted_liberal_arts")
+        end
+      end
     end
 
     context 'when author is not in college of liberal arts' do

spec/integration/author/submission_access_level_spec.rb

@@ -46,34 +46,40 @@
         click_button('Submit final files for review')
         expect(page).not_to have_content('Invention disclosure number is required for Restricted submissions.')
       end
+    end
 
-      context 'when graduate author is in college of liberal arts' do
-        unless current_partner.honors?
-          before do
-            submission.update(academic_program: 'LA')
-            page.refresh
-          end
-
-          it 'has a restricted_liberal_arts radio button' do
-            page.find("input#submission_access_level_restricted_liberal_arts").click
-            expect(page.find("input#submission_access_level_restricted_liberal_arts")).to be_checked
-            expect(page).not_to have_content('Enter justification')
-            expect(page).not_to have_field('submission_invention_disclosures_attributes_0_id_number')
-          end
-        end
+    context 'when author is in college of liberal arts' do
+      before do
+        submission.update(academic_program: 'LA')
+        page.refresh
       end
 
-      context 'when author is not in college of liberal arts' do
-        before do
-          submission.update(academic_program: 'CA')
-          page.refresh
+      if current_partner.graduate?
+        it 'has a restricted_liberal_arts radio button' do
+          page.find("input#submission_access_level_restricted_liberal_arts").click
+          expect(page.find("input#submission_access_level_restricted_liberal_arts")).to be_checked
+          expect(page).not_to have_content('Enter justification')
+          expect(page).not_to have_field('submission_invention_disclosures_attributes_0_id_number')
         end
+      end
 
+      unless current_partner.graduate?
         it 'does not have a restricted_liberal_arts radio button' do
           expect(page).not_to have_selector("input#submission_access_level_restricted_liberal_arts")
         end
       end
     end
+
+    context 'when author is not in college of liberal arts' do
+      before do
+        submission.update(academic_program: 'CA')
+        page.refresh
+      end
+
+      it 'does not have a restricted_liberal_arts radio button' do
+        expect(page).not_to have_selector("input#submission_access_level_restricted_liberal_arts")
+      end
+    end
   end
 
   context 'milsch authors cannot choose the access level', :milsch do

spec/models/submission_spec.rb

@@ -184,7 +184,7 @@
                         access_level: 'restricted_liberal_arts'
     end
 
-    it 'returns submissions that are ready for autorelease' do
+    it 'returns submissions that need a release warning' do
       expect(described_class.release_warning_needed?).to contain_exactly(sub1, sub5)
     end
   end