Merge pull request #1852 from psu-libraries/1851_bot_requests

Ignore Bot Requests to /resources/{uuid} That Trigger Noise & Bugsnag Alerts

Author: granta03

.circleci/config.yml

@@ -121,7 +121,7 @@ jobs:
     - run:
         name: "Bundle"
         command: |
-          gem install bundler
+          gem install bundler -v "$(grep -A 1 "BUNDLED WITH" Gemfile.lock | tail -n 1)"
           bundle check --path vendor/bundle || bundle install --deployment
     - run:
         name: "Yarn"

app/controllers/resources_controller.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 class ResourcesController < ApplicationController
+  rescue_from ActiveRecord::RecordNotFound, with: :resource_not_found
+
   def show
     @resource = ResourceDecorator.decorate(find_resource(params[:id]))
     authorize @resource
@@ -49,4 +51,13 @@ def alternate_format_request_params
           :title
         )
     end
+
+    def resource_not_found(exception)
+      if request.get? && request.path.match?(%r{^/resources/[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$})
+        Bugsnag.notify(exception, &:ignore!)
+        head :not_found
+      else
+        raise exception
+      end
+    end
 end

spec/controllers/resources_controller_spec.rb

@@ -77,12 +77,24 @@
 
     context 'when requesting an unknown uuid' do
       it do
+        allow(Bugsnag).to receive(:notify)
         expect {
           get :show, params: { id: 'not-a-valid-uuid' }
         }.to raise_error(ActiveRecord::RecordNotFound)
       end
     end
 
+    context 'when requesting an unknown uuid that follows uuid pattern' do
+      it do
+        allow(Bugsnag).to receive(:notify)
+        expect {
+          get :show, params: { id: '123e4567-e89b-12d3-a456-426614174000' }
+        }.not_to raise_error(ActiveRecord::RecordNotFound)
+        expect(Bugsnag).to have_received(:notify).with(ActiveRecord::RecordNotFound, &:ignore!)
+        expect(response).to have_http_status :not_found
+      end
+    end
+      
     context 'when the resource is valid with no access' do
       let(:work) { create(:work, :with_no_access) }