Hotfix - reindex work versions after thumbnail generation (#1889)

* Reindex work versions in thumbnail job if uploaded file is not a thumbnail upload (ie autogenerated)

* Niftany

* fix thumbnail upload index update condition

Author: ajkiessl

app/jobs/shrine/thumbnail_job.rb

@@ -9,9 +9,16 @@ def perform(record)
       attacher.create_derivatives :thumbnail
       record.save
     end
-    # If the created record is a thumbnail uploaded by a user,
-    # then the associated resource needs to be reindexed
-    record.thumbnail_upload.resource.update_index if record.thumbnail_upload.present?
+
+    if record.thumbnail_upload.present?
+      # If the created record is a thumbnail uploaded by a user,
+      # then the associated resource needs to be reindexed
+      record.thumbnail_upload.resource.update_index
+    else
+      # Update WorkVersions' solr docs with thumbnail url when
+      # thumbnail is auto-generated from a WorkVersion upload
+      record.work_versions.each(&:update_index)
+    end
   rescue Shrine::AttachmentChanged, ActiveRecord::RecordNotFound
     # attachment has changed or record has been deleted, nothing to do
   end

spec/jobs/shrine/thumbnail_job_spec.rb

@@ -22,5 +22,27 @@
       described_class.perform_now(image_record)
       expect(image_record.file_attacher.url(:thumbnail)).to include('thumbnails')
     end
+
+    it 'reindexes associated work versions when no thumbnail upload is present' do
+      work_version_one = instance_spy(WorkVersion)
+      work_version_two = instance_spy(WorkVersion)
+      allow(pdf_record).to receive_messages(work_versions: [work_version_one, work_version_two], thumbnail_upload: nil)
+
+      described_class.perform_now(pdf_record)
+
+      expect(work_version_one).to have_received(:update_index)
+      expect(work_version_two).to have_received(:update_index)
+    end
+
+    it 'reindexes associated thumbnail upload resource when present' do
+      thumbnail_upload = create(:thumbnail_upload)
+      resource = thumbnail_upload.resource
+      allow(resource).to receive(:update_index)
+      allow(pdf_record).to receive_messages(work_versions: [], thumbnail_upload: thumbnail_upload)
+
+      described_class.perform_now(pdf_record)
+
+      expect(resource).to have_received(:update_index)
+    end
   end
 end