Merge pull request #1839 from psu-libraries/1828-accessible-file-naming

1828 accessible file naming

Author: jlandiseigsti

app/services/build_auto_remediated_work_version.rb

@@ -7,7 +7,7 @@ class NotNewestReleaseError < StandardError; end
 
   def self.call(file_resource, remediated_file_url)
     wv_being_remediated = file_resource.latest_remediation_work_version_candidate
-
+    original_filename = file_resource.file_data['metadata']['filename']
     # In the rare case a new work version is published after the remediation
     # job started, we stop the creation of a new remediated version here.
     unless wv_being_remediated.latest_published_version?
@@ -30,11 +30,7 @@ def self.call(file_resource, remediated_file_url)
         fvm_to_destroy&.destroy!
 
         replacement_tempfile = Down.download(remediated_file_url)
-        built_work_version.file_resources.create!(
-          file: replacement_tempfile,
-          auto_remediated_version: true
-        )
-
+        build_file_resource(built_work_version, replacement_tempfile, original_filename)
         if built_work_version.has_remaining_auto_remediation_jobs?
           built_work_version.save!
         else
@@ -46,7 +42,17 @@ def self.call(file_resource, remediated_file_url)
     end
   end
 
-  def self.on_publish(built_work_version)
+  private_class_method def self.build_file_resource(work_version, replacement_tempfile, original_filename)
+    new_resource = work_version.file_resources.create!(
+      file: replacement_tempfile,
+      auto_remediated_version: true
+    )
+
+    new_resource.file_data['metadata']['filename'] = "ACCESSIBLE_VERSION_#{original_filename}"
+    new_resource.save!
+  end
+
+  private_class_method def self.on_publish(built_work_version)
     built_work_version.publish!
     lib_answers = LibanswersApiService.new
     lib_answers.admin_create_ticket(built_work_version.work.id, 'work_remediation')

spec/services/build_auto_remediated_work_version_spec.rb

@@ -50,14 +50,18 @@
       context 'when no auto-remediated work version exists after the one being remediated' do
         context 'when no remaining remediation jobs' do
           it 'builds a new work version, attaches the remediated file, and publishes' do
-            allow(Down).to receive(:download).with(remediated_url).and_return(Tempfile.new('remediated'))
+            allow(Down).to receive(:download).with(remediated_url).and_return(Tempfile.new('COMPLIANT'))
             wv_count_before = WorkVersion.count
 
             result = described_class.call(file_resource, remediated_url)
             expect(WorkVersion.count).to eq(wv_count_before + 1)
             expect(FileResource).to exist(file_resource.id)
             expect(FileVersionMembership.find_by(work_version: result, file_resource: file_resource)).to be_nil
-            expect(WorkVersion.find(result.id).file_resources.where(auto_remediated_version: true).count).to eq(1)
+            remediated_file_resource = WorkVersion.find(result.id).file_resources.where(auto_remediated_version: true)
+            expect(remediated_file_resource.count).to eq(1)
+            expect(remediated_file_resource.first.file_data['metadata']['filename']).to eq(
+              "ACCESSIBLE_VERSION_#{FileResource.find(file_resource.id).file_data['metadata']['filename']}"
+            )
             expect(result.external_app).to eq(ExternalApp.pdf_accessibility_api)
             expect(result).to be_published
             expect(AutoRemediationNotifications)
@@ -88,7 +92,11 @@
             expect(WorkVersion.count).to eq(wv_count_before + 1)
             expect(FileResource).to exist(file_resource.id)
             expect(FileVersionMembership.find_by(work_version: result, file_resource: file_resource)).to be_nil
-            expect(WorkVersion.find(result.id).file_resources.where(auto_remediated_version: true).count).to eq(1)
+            remediated_file_resource = WorkVersion.find(result.id).file_resources.where(auto_remediated_version: true)
+            expect(remediated_file_resource.count).to eq(1)
+            expect(remediated_file_resource.first.file_data['metadata']['filename']).to eq(
+              "ACCESSIBLE_VERSION_#{FileResource.find(file_resource.id).file_data['metadata']['filename']}"
+            )
             expect(result.external_app).to eq(ExternalApp.pdf_accessibility_api)
             expect(result).to be_draft
             expect(AutoRemediationNotifications)
@@ -122,7 +130,11 @@
             expect(WorkVersion.count).to eq(wv_count_before)
             expect(FileResource).to exist(file_resource.id)
             expect(FileVersionMembership.find_by(work_version: result, file_resource: file_resource)).to be_nil
-            expect(WorkVersion.find(result.id).file_resources.where(auto_remediated_version: true).count).to eq(1)
+            remediated_file_resource = WorkVersion.find(result.id).file_resources.where(auto_remediated_version: true)
+            expect(remediated_file_resource.count).to eq(1)
+            expect(remediated_file_resource.first.file_data['metadata']['filename']).to eq(
+              "ACCESSIBLE_VERSION_#{FileResource.find(file_resource.id).file_data['metadata']['filename']}"
+            )
             expect(result.external_app).to eq(ExternalApp.pdf_accessibility_api)
             expect(result).to be_published
             expect(AutoRemediationNotifications)
@@ -153,7 +165,11 @@
             expect(WorkVersion.count).to eq(wv_count_before)
             expect(FileResource).to exist(file_resource.id)
             expect(FileVersionMembership.find_by(work_version: result, file_resource: file_resource)).to be_nil
-            expect(WorkVersion.find(result.id).file_resources.where(auto_remediated_version: true).count).to eq(1)
+            remediated_file_resource = WorkVersion.find(result.id).file_resources.where(auto_remediated_version: true)
+            expect(remediated_file_resource.count).to eq(1)
+            expect(remediated_file_resource.first.file_data['metadata']['filename']).to eq(
+              "ACCESSIBLE_VERSION_#{FileResource.find(file_resource.id).file_data['metadata']['filename']}"
+            )
             expect(result.external_app).to eq(ExternalApp.pdf_accessibility_api)
             expect(result).to be_draft
             expect(AutoRemediationNotifications)